Changeset 9935

Timestamp:

05/28/2020 03:30:42 AM (4 years ago)

Author:

dd32

Message:

Theme Directory: Don't unset the global $post variable which causes a lot of "weird" failures of functions on a cold cache.

This should resolve the long-standing "what is going on here" questions on the Theme Directory when it comes to the SEO oddities.

See r9949-dotorg (5 years ago).
See #4994.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-themes-api.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-themes-api.php

@@ -757 +757 @@
         }
 
-        if ( $this->fields['template'] || $this->fields['parent'] ) {
-            /*
-             * On requests for single themes the post global can be set, returning that theme as the parent
-             * if the current theme is not a child theme.
-             */
-            unset( $GLOBALS['post'] );
-
+        if ( $theme->post_parent && ( $this->fields['template'] || $this->fields['parent'] ) ) {
             $parent = get_post( $theme->post_parent );
 
-            if ( is_a( $parent, 'WP_Post' ) ) {
+            if ( $parent ) {
                 if ( $this->fields['template'] ) {
                     $phil->template = $parent->post_name;