Changeset 9995

Timestamp:

07/02/2020 07:35:55 AM (5 years ago)

Author:

dd32

Message:

Plugin Directory: When creating temporary files, use a second chmod() call to set them to world-writable as $mode on mkdir() respects the umask.

Fixes some PHP Notices that will be encountered on dev sites when PHP and CLI run as different users.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/tools/class-filesystem.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/tools/class-filesystem.php

@@ -28 +28 @@
     public static function temp_directory( $prefix = '' ) {
         if ( ! is_dir( self::TMP_DIR ) ) {
-            mkdir( self::TMP_DIR, 0777 );
+            mkdir( self::TMP_DIR );
+            chmod( self::TMP_DIR, 0777 );
         }
 
@@ -36 +37 @@
         // Replace that filename with a directory.
         unlink( $tmp_dir );
-        mkdir( $tmp_dir, 0777 );
+        mkdir( $tmp_dir );
+        chmod( $tmp_dir, 0777 );
 
         // Automatically remove this temporary directory on shutdown: