WordPress.org

Making WordPress.org

Changeset 9996


Ignore:
Timestamp:
07/02/2020 07:52:03 AM (19 months ago)
Author:
dd32
Message:

Plugin Directory: Ignore any query vars that the directory doesn't need/use.

See #5290.

Location:
sites/trunk/wordpress.org/public_html/wp-content/plugins
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

    r9994 r9996  
    4646        add_action( 'template_redirect', array( $this, 'custom_redirects' ), 1 );
    4747        add_action( 'template_redirect', array( $this, 'geopattern_icon_route' ), 0 );
    48         add_filter( 'query_vars', array( $this, 'filter_query_vars' ) );
     48        add_filter( 'query_vars', array( $this, 'filter_query_vars' ), 1 );
    4949        add_filter( 'single_term_title', array( $this, 'filter_single_term_title' ) );
    5050        add_filter( 'the_content', array( $this, 'filter_rel_nofollow_ugc' ) );
     
    11581158        $vars[] = 'geopattern_icon';
    11591159
    1160         return $vars;
     1160        // Remove support for any query vars the Plugin Directory doesn't support/need.
     1161        $not_needed = [
     1162            'm', 'w', 'year', 'monthnum', 'day', 'hour', 'minute', 'second',
     1163            'posts', 'withcomments', 'withoutcomments', 'favicon', 'cpage',
     1164            'search', 'exact', 'sentence', 'calendar', 'more', 'tb', 'pb',
     1165            'attachment', 'attachment_id', 'subpost', 'subpost_id', 'preview',
     1166            'post_format', 'cat', 'category_name', 'tag', // We use custom cats/tags.
     1167        ];
     1168
     1169        return array_diff( $vars, $not_needed );
    11611170    }
    11621171
     
    13031312            ( is_tax() || is_category() || is_tag() ) &&
    13041313            ! have_posts() &&
    1305             ! is_tax( 'plugin_section' ) // All sections have something, or intentionall don't (favorites)
     1314            ! is_tax( 'plugin_section' ) // All sections have something, or intentionally don't (favorites)
    13061315        ) {
    13071316            // [1] => plugins [2] => tags [3] => example-plugin-name [4..] => random().
  • sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/query-modifications.php

    r9992 r9996  
    216216    $not_needed = [
    217217        'm', 'w', 'year', 'monthnum', 'day', 'hour', 'minute', 'second',
    218         'posts', 'withcomments', 'withoutcomments',
     218        'posts', 'withcomments', 'withoutcomments', 'favicon', 'cpage',
    219219        'search', 'exact', 'sentence', 'calendar', 'more', 'tb', 'pb',
    220220        'attachment', 'attachment_id', 'subpost', 'subpost_id', 'preview',
    221         'favicon', 'cpage', 'embed', 'post_format',
    222         'cat', 'category_name',
     221        'post_format', 'cat', 'category_name',
    223222    ];
    224223
Note: See TracChangeset for help on using the changeset viewer.