Making WordPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#1018 closed enhancement (fixed)

Enable HiDPI versions of Gravatars for browsers that support srcset

Reported by: ocean90 Owned by: ocean90
Milestone: Priority: normal
Component: Trac Keywords: has-patch

Attachments (1)

1018.patch (4.0 KB) - added by ocean90 3 years ago.

Download all attachments as: .zip

Change History (6)

3 years ago

#1 @ocean90
3 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 1704:

Trac Gravatars: Enable HiDPI versions for browsers that support srcset.

fixes #1018.

#2 @rachelbaker
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@ocean90 The *owned by* avatar on Trac is displaying the avatar for the *reported by* user


Looks like:
<img class="avatar" src="//wordpress.org/grav-redirect.php?user=${ticket.owner}&amp;s=36" srcset="//wordpress.org/grav-redirect.php?user=${ticket.reporter}&amp;s=72 2x" height="36" width="36" />

should be changed to:

<img class="avatar" src="//wordpress.org/grav-redirect.php?user=${ticket.owner}&amp;s=36" srcset="//wordpress.org/grav-redirect.php?user=${ticket.owner}&amp;s=72 2x" height="36" width="36" />

This ticket was mentioned in Slack in #meta by netweb. View the logs.

3 years ago

#4 @ocean90
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 1710:

Trac Gravatars: Use the right variable for ticket owner's gravatar, see [1704].

props rachelbaker.
fixes #1018.

#5 @ocean90
3 years ago

In 1714:

Trac Notifications: Enable HiDPI version of gravatars in wporg_trac_notifications::ticket_notes() for browsers that support srcset.

see #1018.

Note: See TracTickets for help on using tickets.