WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#1035 closed defect (fixed)

RTL issues in local theme directory

Reported by: ramiy Owned by: dd32
Milestone: Priority: normal
Component: Theme Directory Keywords:
Cc:

Description (last modified by dd32)

Hi,

Compare those links to see the issues:

https://he.wordpress.org/
https://he.wordpress.org/themes/

  1. There are no RTL styles for the themes directory

Change History (13)

#1 @dd32
4 years ago

The footer was a known issue, trac'd it here: #1036

Hadn't tested it on a RTL site until pushing the change out, so we'll need to put together a RTL stylesheet for these themes.

#2 @dd32
4 years ago

In 1594:

Themes Directory: Add a RTL stylesheet, this is the LTR stylesheet run through grunt-rtlcss.
See #1035

#3 @dd32
4 years ago

r1594 adds a RTL stylesheet using grunt-rtlcss, which fixes most of the layout issues.

A few small things remain at first glance, such as the icons (dashicons) which need to be flipped to their RTL counterparts using specific .rtl overrides.

#4 @ramiy
4 years ago

Very nice, seems like all the RTL issues in the "Theme Directory" are fixed.

#5 @dd32
4 years ago

Can you check the Singular view: https://he.wordpress.org/themes/twentythirteen/
It looks like the arrows there need to be flipped around (in the Theme Website, and return to search results section)

If you perform a search, and then enter a view, do the Next/Back links work as you'd expect them to in RTL?

#6 @ramiy
4 years ago

Great work!!

#7 @ramiy
4 years ago

Seems like the footer is aligned to left.

In the main page (https://he.wordpress.org/) it looks good
but in the themes directory (https://he.wordpress.org/themes/) it's not
because the theme directory is fullwidth.

I think you need to align the footer text to the center like in https://wordpress.org/

#8 @ramiy
4 years ago

Also, seems like the mobile view is broken.

This ticket was mentioned in Slack in #polyglots by dd32. View the logs.


4 years ago

#10 @dd32
4 years ago

  • Description modified (diff)
  • Summary changed from RTL issues in local theme/plugin directories to RTL issues in local theme directory

Spinning off individual issues to new tickets for easier tracking.

Global Footer issues -> #1036
Mobile view -> #1039
Plugins Directory RTL -> #1040

If there's any issues other than RTL in the themes directory, just create a new ticket for each specific issue, otherwise some might be missed.

#11 @dd32
4 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 1634:

Themes Directory: Flip the arrow icons for RTL viewports.
Fixes #1052, #1035

#12 @McGuive7
4 years ago

Also, what's with the two current/parent nav items (indicated by the upward-facing triangle) in the header nav on this page: https://he.wordpress.org/themes/

It looks like the News (חדשות) page is for some reason resolving as the parent of the themes (תבניות) page. Not sure what's going on there, but it doesn't match the English version of the site.

#13 @dd32
4 years ago

Also, what's with the two current/parent nav items (indicated by the upward-facing triangle) in the header nav on this page: https://he.wordpress.org/themes/

Known issue from the Global header, I've been afk and wasn't able to fix it before I left. Should be fixed in the next couple of days.

Note: See TracTickets for help on using tickets.