RTL issues in local theme directory

[ramiy]

Hi,

Compare those links to see the issues:

​https://he.wordpress.org/
​https://he.wordpress.org/themes/

1. There are no RTL styles for the themes directory

[dd32]

The footer was a known issue, trac'd it here: #1036

Hadn't tested it on a RTL site until pushing the change out, so we'll need to put together a RTL stylesheet for these themes.

[dd32]

In 1594:

Themes Directory: Add a RTL stylesheet, this is the LTR stylesheet run through grunt-rtlcss.
See #1035

[dd32]

r1594 adds a RTL stylesheet using grunt-rtlcss, which fixes most of the layout issues.

A few small things remain at first glance, such as the icons (dashicons) which need to be flipped to their RTL counterparts using specific .rtl overrides.

[ramiy]

Very nice, seems like all the RTL issues in the "Theme Directory" are fixed.

[dd32]

Can you check the Singular view: ​https://he.wordpress.org/themes/twentythirteen/
It looks like the arrows there need to be flipped around (in the Theme Website, and return to search results section)

If you perform a search, and then enter a view, do the Next/Back links work as you'd expect them to in RTL?

[ramiy]

Great work!!

[ramiy]

Seems like the footer is aligned to left.

In the main page (​https://he.wordpress.org/) it looks good
but in the themes directory (​https://he.wordpress.org/themes/) it's not
because the theme directory is fullwidth.

I think you need to align the footer text to the center like in ​https://wordpress.org/

[ramiy]

Also, seems like the mobile view is broken.

[dd32]

Spinning off individual issues to new tickets for easier tracking.

Global Footer issues -> #1036
Mobile view -> #1039
Plugins Directory RTL -> #1040

If there's any issues other than RTL in the themes directory, just create a new ticket for each specific issue, otherwise some might be missed.

[dd32]

In 1634:

Themes Directory: Flip the arrow icons for RTL viewports.
Fixes #1052, #1035

[McGuive7]

Also, what's with the two current/parent nav items (indicated by the upward-facing triangle) in the header nav on this page: ​https://he.wordpress.org/themes/

It looks like the News (חדשות) page is for some reason resolving as the parent of the themes (תבניות) page. Not sure what's going on there, but it doesn't match the English version of the site.

[dd32]

Also, what's with the two current/parent nav items (indicated by the upward-facing triangle) in the header nav on this page: ​https://he.wordpress.org/themes/

Known issue from the Global header, I've been afk and wasn't able to fix it before I left. Should be fixed in the next couple of days.