Making WordPress.org

Opened 9 years ago

Last modified 9 years ago

#1035 closed defect (bug)

RTL issues in local theme directory — at Version 10

Reported by: ramiy's profile ramiy Owned by:
Milestone: Priority: normal
Component: Theme Directory Keywords:
Cc:

Description (last modified by dd32)

Hi,

Compare those links to see the issues:

https://he.wordpress.org/
https://he.wordpress.org/themes/

  1. There are no RTL styles for the themes directory

Change History (10)

#1 @dd32
9 years ago

The footer was a known issue, trac'd it here: #1036

Hadn't tested it on a RTL site until pushing the change out, so we'll need to put together a RTL stylesheet for these themes.

#2 @dd32
9 years ago

In 1594:

Themes Directory: Add a RTL stylesheet, this is the LTR stylesheet run through grunt-rtlcss.
See #1035

#3 @dd32
9 years ago

r1594 adds a RTL stylesheet using grunt-rtlcss, which fixes most of the layout issues.

A few small things remain at first glance, such as the icons (dashicons) which need to be flipped to their RTL counterparts using specific .rtl overrides.

#4 @ramiy
9 years ago

Very nice, seems like all the RTL issues in the "Theme Directory" are fixed.

#5 @dd32
9 years ago

Can you check the Singular view: https://he.wordpress.org/themes/twentythirteen/
It looks like the arrows there need to be flipped around (in the Theme Website, and return to search results section)

If you perform a search, and then enter a view, do the Next/Back links work as you'd expect them to in RTL?

#6 @ramiy
9 years ago

Great work!!

#7 @ramiy
9 years ago

Seems like the footer is aligned to left.

In the main page (https://he.wordpress.org/) it looks good
but in the themes directory (https://he.wordpress.org/themes/) it's not
because the theme directory is fullwidth.

I think you need to align the footer text to the center like in https://wordpress.org/

#8 @ramiy
9 years ago

Also, seems like the mobile view is broken.

This ticket was mentioned in Slack in #polyglots by dd32. View the logs.


9 years ago

#10 @dd32
9 years ago

  • Description modified (diff)
  • Summary changed from RTL issues in local theme/plugin directories to RTL issues in local theme directory

Spinning off individual issues to new tickets for easier tracking.

Global Footer issues -> #1036
Mobile view -> #1039
Plugins Directory RTL -> #1040

If there's any issues other than RTL in the themes directory, just create a new ticket for each specific issue, otherwise some might be missed.

Note: See TracTickets for help on using tickets.