WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 2 years ago

Last modified 2 years ago

#1079 closed defect (fixed)

Exclude Tweets from Insert/Edit Link search

Reported by: siobhan Owned by: iandunn
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: good-first-bug has-patch
Cc:

Description (last modified by siobhan)

The search feature on Insert/Edit link is rendered useless because the search includes tweets. It would be useful to exclude these from the search (see image for what I mean).

https://cldup.com/1U4iXolBLA.png

Attachments (2)

1079.diff (1.8 KB) - added by JasonM4563 4 years ago.
1079.2.diff (1.9 KB) - added by JasonM4563 3 years ago.
Updated Patch

Download all attachments as: .zip

Change History (10)

#1 @siobhan
4 years ago

  • Description modified (diff)

#2 @iandunn
4 years ago

  • Keywords needs-patch good-first-bug added
  • Owner set to iandunn
  • Status changed from new to accepted

Agreed.

#3 @iandunn
4 years ago

The tweets (and related) post types are part of Tagregator, for anyone looking to submit a patch.

@JasonM4563
4 years ago

#4 @JasonM4563
4 years ago

  • Keywords has-patch added; needs-patch removed

Added a filter to remove the CPTs from the search results when adding a link to a post.

#5 @iandunn
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Great, thanks AJ :)

Commited in plugins 1275689

#6 @JasonM4563
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Found a better way to resolve this which is more future proof and better utilizes the existing class variable. Reopening to submit new patch.

@JasonM4563
3 years ago

Updated Patch

#7 @coreymckrill
2 years ago

  • Resolution set to maybelater
  • Status changed from reopened to closed

The first patch seems to be working. The second one could be incorporated into a larger set of improvements to the plugin later, but it's not a priority now.

#8 @SergeyBiryukov
2 years ago

  • Resolution changed from maybelater to fixed

The only difference between 1079.2.diff and https://plugins.trac.wordpress.org/changeset/1275689 appears to be the placement of exclude_from_insert_link_results() in tagregator.php vs. tggr-media-source.php, which doesn't seem like much of an improvement, so I think it's safe to close this as fixed in comment:5.

Note: See TracTickets for help on using tickets.