#1079 closed defect (bug) (fixed)
Exclude Tweets from Insert/Edit Link search
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Component: | WordCamp Site & Plugins | Keywords: | good-first-bug has-patch |
| Cc: |
Description (last modified by )
The search feature on Insert/Edit link is rendered useless because the search includes tweets. It would be useful to exclude these from the search (see image for what I mean).
Attachments (2)
Change History (10)
#2
@
9 years ago
- Keywords needs-patch good-first-bug added
- Owner set to iandunn
- Status changed from new to accepted
#3
@
9 years ago
The tweets (and related) post types are part of Tagregator, for anyone looking to submit a patch.
#4
@
9 years ago
- Keywords has-patch added; needs-patch removed
Added a filter to remove the CPTs from the search results when adding a link to a post.
#5
@
9 years ago
- Resolution set to fixed
- Status changed from accepted to closed
Great, thanks AJ :)
Commited in plugins 1275689
#6
@
8 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Found a better way to resolve this which is more future proof and better utilizes the existing class variable. Reopening to submit new patch.
#7
@
7 years ago
- Resolution set to maybelater
- Status changed from reopened to closed
The first patch seems to be working. The second one could be incorporated into a larger set of improvements to the plugin later, but it's not a priority now.
#8
@
7 years ago
- Resolution changed from maybelater to fixed
The only difference between 1079.2.diff and https://plugins.trac.wordpress.org/changeset/1275689 appears to be the placement of exclude_from_insert_link_results() in tagregator.php vs. tggr-media-source.php, which doesn't seem like much of an improvement, so I think it's safe to close this as fixed in comment:5.
Agreed.