WordPress.org
Get WordPress

Making WordPress.org

Opened 8 years ago

Closed 3 years ago

#1114 closed defect (bug) (reported-upstream)

Site Cloner: Confirm dialog is displayed when switching sites

Reported by: iandunn's profile iandunn Owned by:
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: needs-patch good-first-bug
Cc:

Description

Sometimes the browser will display an unwanted confirmation dialog when the user is previewing multiple themes in succession.

Steps to reproduce:

  1. Browse to any site
  2. Browse to another site that uses the same theme
  3. Browse to a site that uses a different theme

The action at step 2 will trigger an input field in the Customizer to change, so when you try to browse to to a different URL at step 3, the browser thinks you've left a form partially filled-out, and warns you that you'll lose the entered values. That's technically true, but not applicable in this context.

IIRC, Core has some code to get around the same issue, maybe in the Theme Switcher.

Change History (5)

#1 @iandunn
8 years ago

  • Keywords good-first-bug added

#2 @iandunn
8 years ago

  • Owner set to iandunn
  • Status changed from new to accepted

#3 @iandunn
7 years ago

  • Keywords changed from needs-patch, good-first-bug to needs-patch good-first-bug

I think it's actually the Customizer itself that's creating the AYS, and switching to ​setting-less controls would fix it. I'm not 100% sure that they're a good fit for this use case, it seems like they are at first glance.

#4 @iandunn
6 years ago

  • Owner iandunn deleted
  • Status changed from accepted to assigned

#5 @dd32
3 years ago

  • Resolution set to reported-upstream
  • Status changed from assigned to closed

This ticket has been moved to GitHub ​https://github.com/WordPress/wordcamp.org/issues/582

Note: See TracTickets for help on using tickets.