WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 4 years ago

#1133 closed defect (fixed)

Forums theme: Improve sidebar design

Reported by: Xtraboy Owned by: samuelsidler
Milestone: Priority: normal
Component: International Forums Keywords: needs-patch
Cc:

Description

In our Italian forum we have this front-end bug with the Last activity data that goes on new row creating some visual issues. The sidebar column can be more wider without destructing the layout.

This CSS overwrites the width: 240px of the div.sidebar:

@media screen and (min-width: 960px)
div.sidebar {
  width: 212px;
}

Attachments (1)

Screen Shot 2015-07-17 at 15.04.14.png (78.1 KB) - added by Xtraboy 4 years ago.

Download all attachments as: .zip

Change History (10)

#1 @netweb
4 years ago

Sidebar margins were added in r1702, this change overrides the inherited and other responsive styles from the parent theme CSS /buddypress.org/public_html/wp-content/themes/bb-base/style.css. One of the issues I see here is we are still relying on wp4.css in parallel with the parent theme CSS.

I'd like to eliminate wp4.css completely for the i18n forums, we should utilise and iterate on the parent theme CSS for the benefit of all sites that use this theme, bbPress.org, BuddyPress.org and locale.wordpress.org/forums.

The main issue I see in dropping wp4.css would be we'd need to tweak w.org's header.php for the i18n forum sites locale.wordpress.org/forums, we already do something similar for the current 1.x forums at wordpress.org/support and locale.forums.wordpress.org.

#2 @netweb
4 years ago

  • Summary changed from Sidebar data goes on new row and creating an empty space to Forums theme: Sidebar data goes on new row and creating an empty space

#3 @netweb
4 years ago

  • Summary changed from Forums theme: Sidebar data goes on new row and creating an empty space to Forums theme: Fix sidebar and improve responsive design

#4 @netweb
4 years ago

#1136 was marked as a duplicate.

#5 @netweb
4 years ago

Another instance of the sidebar view not as expected, again can be fixed with bb-base styles:
https://it.wordpress.org/forums/topic-tag/editor/

https://cldup.com/TUR11kj8be.png

This ticket was mentioned in Slack in #meta by ocean90. View the logs.


4 years ago

#7 @ocean90
4 years ago

  • Summary changed from Forums theme: Fix sidebar and improve responsive design to Forums theme: Improve sidebar design

Let's use #1138 for the mobile design.

#8 @samuelsidler
4 years ago

As I said in another ticket, our forums theme mixed with the bbPress base styles are a mess. We really need to fix that situation at some point.

Case in point: this ticket.

There are a couple of issues on the linked page.

  1. The sidebar has three columns.
  2. There's some unnecessary padding to the left of the sidebar.
  3. The "Topic Tag: [tag]" is missing on the right column.

I was unable to fix the third issue because... well, I have no idea where that exists. I can't find it at all in the bbPress base theme, so I punted on it. We need to revisit all of this and do it over again sometime.

This is what I did:

  1. There are three columns in our version. bbPress.org has two columns. I removed the Topics column and left the Posts column.
  2. I removed the padding.
  3. I removed the breadcrumb by removing the filter (but leaving the code), because it's not very useful right now. (We should have breadcrumbs, but we should have useful and good-looking ones.)

One thing to note is that expanding the width of the sidebar div actually breaks the sidebar on the tag page (yay), so I didn't do that.

This should fix most of the ugliness and, as @ocean90 said, we're handling the responsive work in #1138.

#9 @samuelsidler
4 years ago

  • Owner set to samuelsidler
  • Resolution set to fixed
  • Status changed from new to closed

In 2428:

Forums Theme: Remove breadcrumb, fix sidebar.

Fixes #1133.

Note: See TracTickets for help on using tickets.