WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 4 years ago

#1134 closed defect (fixed)

Forums theme: Forums home search box doesn't return results

Reported by: medariox Owned by: ocean90
Milestone: Priority: high
Component: International Forums Keywords: has-patch
Cc:

Description

The search box located on the forums home doesn't work correctly. On search, the user is redirected to a new page with the error message "Per favore inserisci qualche termine di ricerca qui sopra" (Please enter a search term). The search box on the new page works as expected (see attached picture).

Forums home: https://it.wordpress.org/forums/

Attachments (3)

8bf48d5e1c.png (50.8 KB) - added by medariox 4 years ago.
Forums home search box
67f8e6d344.png (4.9 KB) - added by medariox 4 years ago.
Error page with new search box
1134.diff (1.5 KB) - added by francescolaffi 4 years ago.
search form patch

Download all attachments as: .zip

Change History (11)

@medariox
4 years ago

Forums home search box

@medariox
4 years ago

Error page with new search box

#1 @netweb
4 years ago

The front page search form was updated via c08cfa2 to "better match w.org"...

Is the plan to use bbPress native search so that i18n forums search is restricted to each single locale forum?

Or is the plan to use the "Custom Google Search" to search all of w.org?

Sidenote: Our theme includes two custom bbPress searches, one to search topics in a single forum, and another to search replies in a single topic.

#2 @netweb
4 years ago

Related: #347 Wrong search on all international support forums ( bbPress 1.x i18n Forums)

Quoting dd32 in ticket:347#comment:5:

After taking a quick look at this, I don't think we can re-use the existing wordpress.org/search/ template for Rosetta sites.

The main reason is that it's built statically for the english variant, and localising it isn't really easily possible. Instead, this should be created within the rosetta plugins somehow.

This ticket was mentioned in Slack in #meta by sergey. View the logs.


4 years ago

This ticket was mentioned in Slack in #meta-i18n by ocean90. View the logs.


4 years ago

@francescolaffi
4 years ago

search form patch

#5 @francescolaffi
4 years ago

  • Keywords has-patch added; needs-patch removed

patch 1134.diff generated at sites/trunk/wordpress.org/ level

replacing homepage search form with bbpress standard search template + css fix for broken positioning

#6 follow-up: @nbachiyski
4 years ago

The patch looks great, thanks @francescolaffi!

One thing I am not sure about is whether we’re using the theme at some other place, from what I see – no, but didn’t want to commit this before making sure.

#7 in reply to: ↑ 6 @dd32
4 years ago

Replying to nbachiyski:

One thing I am not sure about is whether we’re using the theme at some other place, from what I see – no, but didn’t want to commit this before making sure.

At present it's only on the new international forums.
The patch looks good to me though!

#8 @ocean90
4 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 2063:

Forums Theme: Use bbPress' search form template on home page.

The custom search form had actions which aren't supported by default in bbPress.

Props francescolaffi.
Fixes #1134.

Note: See TracTickets for help on using tickets.