WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 3 years ago

#1145 closed defect (fixed)

Plugin Directory 404 page's pager is broken

Reported by: hnle Owned by:
Milestone: Priority: normal
Component: Plugin Directory Keywords:
Cc:

Description

in the plugin directory's 404 page, there're show plugins list including near words.
ex: https://wordpress.org/plugins/nothing/

They hav pager and working fine. (ex: https://wordpress.org/plugins/nothing/page/2)

In their subpage(ex: https://wordpress.org/plugins/nothing/developers/), it show same as first, but pager is no working (ex: https://wordpress.org/plugins/nothing/developers/page/2)

Thanks.

Change History (17)

#1 @Otto42
4 years ago

Where did you come up with the link of "https://wordpress.org/plugins/nothing/developers/"? That's not a legitimate page, because there is no plugin named "nothing".

#2 @hnle
4 years ago

I'm sorry, I have missed the reply.

Will is not located in that accessing such pages if the remaining links somewhere in such deleted plugin.
Of course plugin named "nothing" does not exist you know.

Is strange is broken links in the to 404 pages exist.

#3 @Otto42
4 years ago

I'm sorry, but I don't understand your response.

None of your links work. They appear to show proper 404 pages or redirects to proper places to me.

What are you seeing that is incorrect, exactly?

#4 @hnle
4 years ago

I do not know what to do description...

https://cldup.com/t7AweAz4hy.png

Well
https://cldup.com/JU6CZy9M5Z.png

Not good
https://cldup.com/4r1AE55BDB.png

#5 follow-up: @Otto42
4 years ago

Right, I get that, but why are you looking at the /nothing/developers page? That's not linked to from anywhere. That's not a valid link.

#6 in reply to: ↑ 5 @DrewAPicture
4 years ago

Replying to Otto42:

Right, I get that, but why are you looking at the /nothing/developers page? That's not linked to from anywhere. That's not a valid link.

I think the broader point @hnle is making is that there's a bug with the pagination on the 404 page for pages 2+. The first 404 page shows the 404 message + pagination + results. Pages 2+ show the generic wordpress.org 404 page only.

He's using /nothing simply as a way to force the 404 for demonstration pvvvurposes.

#7 @hnle
4 years ago

Thanks @DrewAPicture, right.

#8 @Otto42
4 years ago

Okay, so, would the valid fix here would be to have /nothing/developers redirect you back to /plugins? Because pagination isn't supposed to work there. That's not a valid URL to ever visit. The fact that you get anything at all other than the Page Not Found is the real error.

I just don't quite grasp how you got to /nothing/developers in the first place. Where did this link occur or show up? Because that link should never exist, and if it does, then I want to remove it.

#9 @Otto42
4 years ago

Note: Pagination works perfectly fine on the plugin-not-found pages.

https://wordpress.org/plugins/nothing/page/2

Adding that /developers to the link indeed breaks it, but there's no way to do that other than to type it in manually, as far as I know. Or is this actually linked to from somewhere?

This ticket was mentioned in Slack in #meta by ocean90. View the logs.


3 years ago

#11 @samuelsidler
3 years ago

I think there's three fixes here that we need to do (at some point):

  1. All 404 pages on /plugins should match.
  2. Paging should “redirect” to a real URL once you go to page 2.
  3. All 404 pages should send a 404 status code.

#12 @Ipstenu
3 years ago

Deleted/non-extant plugins now redirect to wordpress.org/plugins

Is there more to do here or can we close this?

#13 @samuelsidler
3 years ago

The new directory in development has an actual 404 page instead of showing search results and returns a 404 error. Does that cover everything in this ticket?

#14 @Ipstenu
3 years ago

That new 404 is adorable. I think we're good :)

#15 @hnle
3 years ago

Looks good!

This ticket was mentioned in Slack in #meta by ipstenu. View the logs.


3 years ago

#17 @Otto42
3 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.