WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 4 years ago

#1149 closed defect (fixed)

Plugin Directory welcome string needs proper plural forums

Reported by: SergeyBiryukov Owned by: coffee2code
Milestone: Priority: normal
Component: Plugin Directory Keywords:
Cc:

Description

There's a string on the Plugin Directory front page:

<strong>%s</strong> plugins with <strong>%s</strong> total downloads are at your fingertips.

It's not localizable due to the lack of _n(). Unless a better option emerges, it should be something like:

printf( __( '%s with %s are at your fingertips' ),
	sprintf( _n( '%s plugin', '%s plugins', $count ), '<strong>' . number_format_i18n( $count ) . '</strong>' ),
	sprintf( _n( '%s total download', '%s total downloads', $downloads ), '<strong>' . number_format_i18n( $downloads ) . '</strong>' ),
);

If we could round the values (39,000+ plugins with 987,841,000+ downloads), that would help too.

Change History (3)

#2 @coffee2code
4 years ago

  • Owner set to coffee2code
  • Status changed from new to accepted

#3 @coffee2code
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed in [10689-dotorg].

We decided to display the unrounded counts until after the billionth download, at which point we'll change the string once more to simply say something akin to "1+ billion downloads".

Note: See TracTickets for help on using tickets.