WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#1163 closed enhancement (fixed)

Display links to slides and WPTV video on individual Session pages

Reported by: lcrdd Owned by: kovshenin
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: good-first-bug has-patch
Cc:

Description

Request that the enhancement resolved in this ticket - https://meta.trac.wordpress.org/ticket/508 - be applied also to individual session pages.

Allowing the slide url and WordPress.tv link to appear on the individual session pages is much more user-friendly as most WordCamps utilize the schedule feature which links to individual session pages. This would allow attendees to view the slide url and WordPress.tv links directly on each session's page instead of having to scroll through a long Sessions page to find what they are looking for.

Attachments (1)

1163.patch (3.5 KB) - added by juanfra 3 years ago.
New functions to filter the content and include links to slides and video. Markup can change. We need to define the site ID from which this feature will be enabled.

Download all attachments as: .zip

Change History (12)

#1 @BrashRebel
4 years ago

  • Cc kyle@… added

#2 @iandunn
4 years ago

  • Keywords needs-patch good-first-bug added
  • Owner set to iandunn
  • Status changed from new to accepted

The Community Team gave this a thumbs up.

#3 @iandunn
4 years ago

#1295 was marked as a duplicate.

@juanfra
3 years ago

New functions to filter the content and include links to slides and video. Markup can change. We need to define the site ID from which this feature will be enabled.

#4 @juanfra
3 years ago

Hey there,

I love this feature! As a WordCamp organizer that's something we struggled with once the event finished. We had to go and edit each session individually. Thanks @lcrdd for posting this ticket!

I've created two simple functions to filter the content, and display the slides and video links (if they're defined).

The HTML markup can change. I included a <div> with a simple class name trying to follow what it is done already.

I also followed a site id "enabling" via script, following what it was done for the rest of the functions. Perhaps @iandunn can help with the ID numbers we should put over there.

Cheers,
Juanfra.

#5 @juanfra
3 years ago

  • Keywords has-patch added; needs-patch removed

#6 @iandunn
3 years ago

Thanks for the patch @juanfra :) I just got back from vacation and am getting caught up on things, but I'll take a look at this and the other patches you submitted this week.

#7 @juanfra
3 years ago

Thanks @iandunn :) I hope you enjoyed your vacation!

#8 @iandunn
3 years ago

  • Owner changed from iandunn to kovshenin
  • Status changed from accepted to assigned

#9 @kovshenin
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 3102:

WordCamp.org: Display links to slides and WordPress.tv videos on session pages.

Fixes #1163
Props juanfra

#10 follow-up: @kovshenin
3 years ago

Thanks for the patch @juanfra, it's deployed now! Not a big deal, but for easier translations it'd be best to use:

sprintf( '<a href="%s" target="_blank">%s</a>', esc_url( $session_video ), esc_html__( 'View Session Video', 'wordcamporg' ) );

Instead of:

sprintf( __( '<a href="%s" target="_blank">View Session Video</a>', 'wordcamporg' ), esc_url( $session_video ) ); 

That way translators won't have to worry about HTML.

#11 in reply to: ↑ 10 @juanfra
3 years ago

Thanks @kovshenin :)

Yeah, it's better that way, I'll have it in mind for future patches.

Cheers and thanks!

Note: See TracTickets for help on using tickets.