Making WordPress.org

Opened 9 years ago

Closed 7 years ago

Last modified 7 years ago

#1178 closed defect (bug) (fixed)

Improve WordPress.org RTL styles and generate RTLCSS via a Grunt task

Reported by: netweb's profile netweb Owned by: obenland's profile obenland
Milestone: Priority: normal
Component: General Keywords: has-patch needs-refresh
Cc:

Description

Improve WordPress.org RTL styles generated by RTLCSS

Similar to r1771 a Gruntfile was added to generate the RTL WordPress.org Themes styles.

Attached patch adds a grunt task grunt build (or grunt rtlcss) to generate RTL stylesheets for the following:

https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/style

  • forum-wp4-rtl.css
  • wp4-rtl.css

Note: An svn:ignore property should also be added for the node_modules folder

Attachments (2)

1178.diff (3.0 KB) - added by netweb 9 years ago.
1178-rtlcss.diff (50.2 KB) - added by netweb 9 years ago.

Download all attachments as: .zip

Change History (13)

@netweb
9 years ago

@netweb
9 years ago

#1 @netweb
9 years ago

In 1178.diff is the base patch and 1178-rtlcss.diff is the result of running grunt build from the /style folder

#2 @netweb
9 years ago

Related: #1068

#3 @netweb
9 years ago

Related: #1255 Plugin Directory (RTL) Sidebar

#4 @ramiy
9 years ago

Related: #1252 Plugin Directory Screenshots in local RTL view
Related: #1253 RTL plugin repo - download btn and favorite link
Related: #1256 Plugin Directory (RTL) Sidebar margin

This ticket was mentioned in Slack in #meta by sam. View the logs.


9 years ago

#6 follow-up: @ocean90
9 years ago

  • Keywords needs-refresh added

Is there a way to combine the tasks with the theme directory sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-themes and other projects? Some type of "global tasks"?

#7 in reply to: ↑ 6 @netweb
9 years ago

Replying to ocean90:

Is there a way to combine the tasks with the theme directory sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-themes and other projects? Some type of "global tasks"?

Probably remove the tasks in the above repo and add a more "global tasks" config further up the repo, the CSS in most of the following top level folders could probably do with this enhancement:

Adding a Gruntfile.js and package.json at https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org and then checking for CSS/JS in all folders under /public_html is the option that comes to mind at the moment.

#8 @obenland
7 years ago

  • Owner set to obenland
  • Status changed from new to accepted

#9 @obenland
7 years ago

In 6518:

Header: Remove iphone stylesheet.

No longer needed, responsive styles are good enough.

See #1178.

#10 @obenland
7 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 6519:

Style: Create RTL styles via grunt task.

At some point we could start writing wp4 in Sass and/or ship a minified version. For now it provides rem unit fallbacks, updates property prefixes, and creates RTL styles.

Props netweb.
Fixes #1178.

#11 @obenland
7 years ago

In 6555:

WP.org: Add a (very) basic build script

Helps with building child theme CSS after parent theme changes.

See #1178.

Note: See TracTickets for help on using tickets.