Making WordPress.org

Opened 9 years ago

Closed 21 months ago

#1207 closed enhancement (fixed)

WPTV: Allow submission of more than one caption file by language

Reported by: jerrysarcastic's profile JerrySarcastic Owned by: dd32's profile dd32
Milestone: Priority: high
Component: WordPress.tv Keywords: good-first-bug has-patch
Cc:

Description

When submitting a subtitle or caption file (TTML) to WordPress.tv, it is only possible to do so for languages where there are no existing captions. If there is a file already attached to the video, that language is greyed out on the upload page.

For example, this vide has a French (FR) subtitle file:
http://wordpress.tv/2015/02/27/kasia-swiderska-clients-from-hell-how-to-recognize-and-deal-with-them/

On the subtitle upload page, French is greyed out and not selectable.
http://wordpress.tv/subtitle/?video=43599

This is a problem for anyone looking to submit an edited/updated caption file for that language, as it is impossible to proceed with uploading if a language is not specified.

Current workaround for this is to ping an moderator in #wptv who has admin access to WordPress.tv, to have them manually un-attach the existing caption file: https://make.wordpress.org/tv/handbook/subtitlescaptions/how-to-update-subtitles-on-wordpress-tv/

Instead, it would be good to make it possible to upload a file (which is held for moderation in any event) even if there is one existing for that language.

As an enhancement we could also show an additional comment field if the uploader selects a language for which we have an existing caption file, so the uploader can add any notes for the mods to see.

Attachments (1)

fix-allow-submitting-subtitle-for-same-language.diff (2.0 KB) - added by robfelty 2 years ago.
fix to allow resubmission of caption for a language which has already been submitted

Download all attachments as: .zip

Change History (11)

This ticket was mentioned in Slack in #wptv by jerrysarcastic. View the logs.


9 years ago

#2 @iandunn
9 years ago

  • Keywords needs-patch good-first-bug added
  • Owner set to iandunn
  • Status changed from new to accepted

Yeah, if they select a language that has already been translated, it'd probably be good to show a message letting them know that it has (in case they weren't aware), and then, if they want to submit it anyway, require them to explain the differences in a new textarea.

#3 @iandunn
7 years ago

  • Owner iandunn deleted
  • Status changed from accepted to assigned

#4 @obenland
6 years ago

  • Type changed from defect to enhancement

#5 @joedolson
5 years ago

  • Priority changed from normal to high

This ticket was mentioned in Slack in #meta by robfelty. View the logs.


2 years ago

#7 @robfelty
2 years ago

  • Keywords has-patch added; needs-patch removed

I worked on this today for contributor day with Arnas Damasickis. I am attaching a patch which will turn this into a warning instead of an error - the warning shows up in the moderation page, using the same warning as the another_approved warning. This is basically the same situation, where there is already an approved translation. It may or may not be from the same author, and if accepted, it will replace the existing one.

@robfelty
2 years ago

fix to allow resubmission of caption for a language which has already been submitted

This ticket was mentioned in Slack in #meta by robfelty. View the logs.


2 years ago

#9 @robfelty
2 years ago

I deployed the change today on the wp.com side. I think it can be closed now.

#10 @dd32
21 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from assigned to closed

In 12041:

WordPress.TV: Allow re uploading subtitles.

This open-sources changes made by robfelty upstream in the WordPress.TV codebase.

Props robfelty.
Fixes #1207.

Note: See TracTickets for help on using tickets.