WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 4 years ago

#1229 closed defect (fixed)

Log translation warnings to slack & review existing warnings for usefulness

Reported by: dd32 Owned by: dd32
Milestone: Priority: normal
Component: Translate Site & Plugins Keywords:
Cc:

Description

As discussed during the #meta-i18n chats, we're going to log translation warnings to Slack to make it easier to identify potentially bad translations.

In addition, we need to review what currently creates a warning, and if anything else should do so.

Current warnings include:

  • String Length - Translation must be between 20% and 500% of the original string length
  • HTML Tags - Translation must contain the same HTML tags & attribute names (The title tag may contain a different translation)
  • Links must match (This is built into the HTML Tags checks above)
  • Placeholders must match (ie. %s, %d, etc)
  • Translation must start/end on a new line if the original does

Change History (5)

#1 @dd32
4 years ago

In 1869:

Translate: Log translation warnings into Slack #polyglots-warnings for peer-review.
This is also likely to help us tweak warning rules to minimise false-positives.

See #1229

#2 @dd32
4 years ago

In 1870:

Translate: Don't log a warning twice in a single request. This can occur when a translation editor triggers a warning as we both save and approve the string in one move.

See #1229

#3 @dd32
4 years ago

In 1871:

Translate: Only log translation warnings for translations who are 'current' or 'waiting'. This avoids rejected strings (upon update) being sent.

See #1229

#4 @samuelsidler
4 years ago

  • Owner set to dd32
  • Status changed from new to assigned

#5 @dd32
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Marking as resolved. Other tickets have added a client-side JS validation & URL validation

Note: See TracTickets for help on using tickets.