WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 4 years ago

#1254 closed enhancement (fixed)

Trac Notifications: improve tense for "subscribe" in trac_notifications_box_render()

Reported by: tyxla Owned by: drewapicture
Milestone: Priority: normal
Component: Trac Keywords: has-patch
Cc:

Description

In trac_notifications_box_render(), the "subscribe" verb is used in present simple. But it makes sense to use present perfect tense there. These texts are displayed in the "Notifications" box of a particular ticket in Trac.

To clarify a bit better, here is a demo of how the notification texts appear right now:

  • You are receiving notifications because you subscribe to the javascript focus.
  • You are receiving notifications because you subscribe to the REST API component.
  • You are receiving notifications because you subscribe to the 4.4 milestone.

After the change I'm suggesting, the texts will appear this way:

  • You are receiving notifications because you have subscribed to the javascript focus.
  • You are receiving notifications because you have subscribed to the REST API component.
  • You are receiving notifications because you have subscribed to the 4.4 milestone.

Attachments (1)

1254.patch (1.5 KB) - added by tyxla 4 years ago.
Improve tense for "subscribe" in trac_notifications_box_render()

Download all attachments as: .zip

Change History (4)

@tyxla
4 years ago

Improve tense for "subscribe" in trac_notifications_box_render()

#1 @tyxla
4 years ago

  • Keywords has-patch added; needs-patch removed

#2 @tyxla
4 years ago

  • Type changed from defect to enhancement

#3 @drewapicture
4 years ago

  • Owner set to drewapicture
  • Resolution set to fixed
  • Status changed from new to closed

In 1917:

Trac: Use present perfect tense for messages conveying focus, component, and milestone subscriptions.

Props tyxla.
Fixes #1254.

Note: See TracTickets for help on using tickets.