Making WordPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#1275 closed defect (fixed)

Theme Directory - theme description is not localized

Reported by: ramiy Owned by: ocean90
Milestone: Priority: normal
Component: Theme Directory Keywords:


So I translated the Twenty Fifteen theme to hebrew:

https://wordpress.org/themes/twentyfifteen/ - Theme page
https://he.wordpress.org/themes/twentyfifteen/ - Theme page in Hebrew
https://translate.wordpress.org/locale/he/default/wp-themes/twentyfifteen - All strings are 100% translated

Even the "Description" string is translated:

But on the plugin page it's still in english.

Change History (4)

#1 @ocean90
6 years ago

That's a bug in the GlotPress Bridge plugin (https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/plugins/glotpress-translate-bridge/glotpress-translate-bridge.php#L160) which assumes that the GlotPress locale for the WordPress locale he_IL is he-il, but it's he.

@dd32: I think we have to use locales.php and use the exisiting implementation as a fallback if locale.php doesn't exist.

#2 @dd32
6 years ago

Remind me again why GlotPress doesn't use WP_Locale as it's slug? (Please don't..)

I guess locales.php reliance is going to be a given here.

#3 @ocean90
6 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 1925:

GlotPress Translate Bridge: Use GP_Locales to get the GlotPress slug of a locale.

The previous version (now used as a fallback) assumed that the GlotPress locale for the WordPress locale he_IL is he-il, but it's he.

Fixes #1275.

#4 @ramiy
6 years ago

Now it's working!

The description is in hebrew and all the tags!

Note: See TracTickets for help on using tickets.