Opened 9 years ago

Closed 6 years ago

Last modified 6 years ago

#1284 closed defect (bug) (fixed) - String localization

Reported by: ramiy's profile ramiy Owned by: netweb's profile netweb
Milestone: Priority: normal
Component: Keywords: has-patch


Many strings on are not localized.

The attached patch is adding _e() and esc_attr_e() to strings.

Very simple fix.

Attachments (3)

meta-1284.patch (13.8 KB) - added by ramiy 9 years ago.
meta-1284.2.patch (14.2 KB) - added by ramiy 9 years ago.
Minor fix - replace 'bborg' textdomain with 'bporg'
1284.3.patch (17.5 KB) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (12)

9 years ago

9 years ago

Minor fix - replace 'bborg' textdomain with 'bporg'

#1 @ramiy
9 years ago


#1284 - String localization
#1285 - String localization

#2 @ramiy
9 years ago

#1287 - String localization

This ticket was mentioned in Slack in #buddypress by ramiy. View the logs.

9 years ago

#4 @SergeyBiryukov
8 years ago

While we're at it, redundant title attributes should be removed:

<a class="feed" href="<?php bbp_forums_url(); ?>feed/" title="All Recent Posts">All Recent Posts</a>

And this one should be moved to the alt attribute for the image:

<a href="" title="BuddyPress Theme Development"><img width="225" alt="A book by: Tammie Lister" src="<?php echo get_stylesheet_directory_uri(); ?>/images/buddypress-packt.jpg"/></a></p> 

#5 @netweb
8 years ago

  • Keywords needs-refresh added

#6 @coffee2code
8 years ago

  • Owner set to netweb
  • Status changed from new to assigned

Assigning to you @netweb (along with #1285 and #2102) since it seems you have them in hand.

#7 @SergeyBiryukov
7 years ago

  • Keywords needs-refresh removed

In 1284.3.patch:

  • Strings like Friendship connections.<br /> It's always about<br /> who you know! should be translated in context, not as three separate strings.
  • Add translator comments.
  • Remove redundant title attributes.

#8 @dd32
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 6364: Localise strings in the BuddyPress theme.

Props SergeyBiryukov, ramiy.
Fixes #1284.

#9 @dd32
6 years ago

In 6365: Remove unused page template.

See #1284.

Note: See TracTickets for help on using tickets.