WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 21 months ago

#1293 closed enhancement (fixed)

WordPress.tv: Full-width video player

Reported by: johnbillion Owned by: obenland
Milestone: Priority: normal
Component: WordPress.tv Keywords: good-first-bug has-patch
Cc:

Description

YouTube provides a toggle that switches the video player between standard size and 'cinema mode', which is a full-width video.

It would be great if WordPress.tv provided a similar toggle. The standard video player is tiny, but I don't always want to go into fullscreen mode.

Alternatively, the video player could be full-width by default.

Attachments (1)

1293.diff (520 bytes) - added by juanfra 2 years ago.
Fix for full-width video player

Download all attachments as: .zip

Change History (11)

#1 @iandunn
4 years ago

  • Keywords needs-patch good-first-bug added; ui-feedback removed
  • Owner set to iandunn
  • Status changed from new to accepted
  • Summary changed from Large view mode for WordPress.tv to WordPress.tv: Full-width video player

#2 @iandunn
4 years ago

The player used to be full-width, but it was unintentionally reset to the standard size when the new player was launched. We just need to update the theme's markup/styles to make it fill the container again.

#3 @juanfra
3 years ago

Hey Ian,

I hope you're doing well. Can you give me an example of the shortcode structure to include viedos? I can take care of this if you want, but I need to know the shortcode structure first to recreate the issue locally.

Best,
Juanfra.

#5 @iandunn
2 years ago

  • Owner iandunn deleted
  • Status changed from accepted to assigned

@juanfra
2 years ago

Fix for full-width video player

#6 @juanfra
2 years ago

Hi there,

This patch fixes the width for iframes within .video-player. This will make the video display full-width.

Would make sense to make it responsive, but I guess that should be done in #974? I'd be more than happy to help there.

Best,
J

#7 @juanfra
2 years ago

  • Keywords has-patch added; needs-patch removed

#8 @juanfra
2 years ago

NOTE: I now see that in the live version of WordPress.tv the video is not wrapped in the div.video-player as it is in the meta-repository(git). That's Jetpack territory.

And it would be dependant on the Jetpack version there. Please check line 130 of wordpress.tv/public_html/wp-content/plugins/jetpack/modules/videopress/class.videopress-player.php (meta-repository)

#9 @juanfra
22 months ago

Hey there,

I hope all's well. I've been watching some WCUS videos this week and it would be great to have the full-width video layout. Have you been able to test the patch?

✌️

#10 @obenland
21 months ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from assigned to closed

In 6373:

WordPress.tv: Bring back full-width videos.

Props juanfra for initial patch.
Fixes #1293.

Note: See TracTickets for help on using tickets.