WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 6 days ago

#1344 closed defect (fixed)

Don't link reserved names

Reported by: johnbillion Owned by: ocean90
Milestone: Priority: normal
Component: Trac Keywords: has-patch
Cc:

Description

Since [1967], instances of @ in code blocks also get linked, which messes up the formatting of commit messages where text such as @since is used. Example of a broken commit message comment: https://core.trac.wordpress.org/ticket/33763?cnum_edit=11#comment:11

To avoid reimplementing wptexturize() in Trac, we could just blacklist some names that shouldn't get linked:

  • access
  • deprecated
  • global
  • ignore
  • internal
  • link
  • method
  • package
  • param
  • return
  • see
  • since
  • subpackage
  • todo
  • type
  • var

Related: #830.

Attachments (3)

1344.diff (1.1 KB) - added by DrewAPicture 4 years ago.
1344-uses.diff (613 bytes) - added by netweb 4 years ago.
1344.2.diff (629 bytes) - added by SergeyBiryukov 4 years ago.

Download all attachments as: .zip

Change History (19)

#1 @DrewAPicture
4 years ago

  • Keywords has-patch added; needs-patch removed

@DrewAPicture
4 years ago

#2 @ocean90
4 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 1993:

Trac: Don't link reserved names.

Props DrewAPicture.
Fixes #1344.
See #830.

#3 @johnbillion
4 years ago

@param got missed.

#4 @johnbillion
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#5 @ocean90
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 1995:

Trac: Add param to the list of reserved terms.

Fixes #1344.

@netweb
4 years ago

#6 @netweb
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@uses also got missed, both bbPress and BuddyPress continue to use @uses

Testing this on core.trac @uses is linked to https://profiles.wordpress.org/uses, but this is not the case for meta, bbPress or BuddyPress, should this feature be available on all Tracs or not yet implemented?

#7 @SergeyBiryukov
4 years ago

ticket was also missed, see #1463. Merged 1344-uses.diff with the patch on that ticket.

#8 @ocean90
4 years ago

#1463 was marked as a duplicate.

#9 @SergeyBiryukov
4 years ago

Added the patch from #1463.

#10 @ocean90
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 2187:

Trac: Update list of reserved terms for linked mentions.

Fixes #1344.

#11 @SergeyBiryukov
22 months ago

In 6501:

Trac: Add covers to the list of reserved terms that should not be converted to a mention.

See #1344.

#12 @SergeyBiryukov
10 months ago

In 8162:

Trac: Add group to the list of reserved terms that should not be converted to a mention.

See #1344.

#13 @SergeyBiryukov
10 months ago

In 8163:

Trac: Bump scripts version after [8162].

See #1344.

#14 @SergeyBiryukov
4 months ago

In 9080:

Trac: Add import to the list of reserved terms that should not be converted to a mention.

See #1344.

#15 @SergeyBiryukov
6 days ago

In 9304:

Trac: Add returns (a synonym for return) to the list of reserved terms that should not be converted to a mention.

See #1344.

#16 @SergeyBiryukov
6 days ago

In 9305:

Trac: Bump scripts version after [9304].

See #1344.

Note: See TracTickets for help on using tickets.