WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 3 years ago

#1348 closed defect (duplicate)

Plugin Translation Editors and duplicate statuses for the same string translation

Reported by: netweb Owned by:
Milestone: Priority: normal
Component: Translate Site & Plugins Keywords:
Cc:

Description

This occurred originally via the steps outlined below and the "Typekit Fonts for WordPress" plugin resulting in ~60 plugins now having both approved and waiting statuses for the same string in each of the ~60 plugins.

Repro Steps:

  1. Add a new user as a "Plugin Translation Editor" e.g. "Typekit Fonts for WordPress"
  1. Translates and approve a string, e.g. Help
  1. Check the waiting tab the locale the string was translated for e.g https://translate.wordpress.org/locale/en-au/default/waiting for strings matching Help that are now waiting for approval e.g Restaurant Reservations

Results:

The plugin translations for Restaurant Reservations contains both an approved and waiting string status for the same Help string

Expected results:

A single translation of the string Help and not two translations with different translation statuses of the same string.

Based on our recent #polyglots discussions of around glossary of terms I'd expect the string to have the waiting status as the original translator is not an approved validator of strings for other plugins in the same locale.

Change History (9)

#1 @SergeyBiryukov
4 years ago

  • Summary changed from Plugin Translation Editors and duplicate statuses for the same string transalation to Plugin Translation Editors and duplicate statuses for the same string translation

This ticket was mentioned in Slack in #meta-i18n by netweb. View the logs.


4 years ago

#3 @netweb
4 years ago

In the "Restaurant Reviews" plugin I used as example links in the original ticket, all of these strings have now been approved so it's not the best example anymore ;)


Here's an example in the Infinite Scroll plugin where I expected the same behaviour as I outlined but it is not the case entirely, the string Loading... is approved whereas strings edit, delete, and cancel are not approved. There are no duplicate strings with duplicate statuses. All 4 of these strings were originally added by a PTE for the Events Manager plugin and I (netweb) approved each of these strings .


Here's another example in the WP System Health where the string Yes has both a waiting and approved translation status per the original ticket description.

#4 @netweb
4 years ago

I think the following would for sure help explain the case above involving the "Infinite Scroll" plugin:

Via @SergeyBiryukov in https://wordpress.slack.com/archives/polyglots/p1446137287000688

"As far as I know, a translation is only propagated to other projects if the context is the same, i.e. the translation for _x( 'Add New', 'post' ) won't be suggested as a translation for __( 'Add New' ) or _x( 'Add New', 'user' )."

This ticket was mentioned in Slack in #meta-i18n by netweb. View the logs.


4 years ago

#6 @ocean90
4 years ago

#1399 was marked as a duplicate.

#7 @ocean90
4 years ago

  • Keywords close added

This should be a ticket on GlotPress' Trac.

This ticket was mentioned in Slack in #polyglots by ocean90. View the logs.


4 years ago

#9 @ocean90
3 years ago

  • Keywords close removed
  • Resolution set to duplicate
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.