WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 3 years ago

#1350 closed enhancement (fixed)

Add draft functionality to Payment Request posts

Reported by: JustinSainton Owned by: iandunn
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: needs-patch good-first-bug
Cc:

Description

It's really helpful for us in our workflows to be able to start payment requests without having all of the information. With as much money going back and forth as there is, it's easy to miss something in the fray, and being able to draft a request, as such, would be really helpful.

Whether that's a matter of being able to set it as a draft, or as incomplete - that would be really awesome to be able to do.

Related: [1816], [1820]

Change History (7)

#1 @jenmylo
4 years ago

Consider this approved from a ux perspective and a WC Central perspective. Just needs someone to write a patch. :)

#2 @JustinSainton
4 years ago

awesome, thanks @jenmylo!

@iandunn, just want to outline my initial thoughts regarding an approach here after reviewing [1816] and [1820].

  • The goal here is to give admins the functionality that only network admins currently have. My thinking is that where the cap checks currently check manage_network, we should check manage_options.
  • In notify_requester_request_incomplete, we'd only want to notify the requester if it is a network admin marking it as incomplete. Therefore, the initial condition inside of that function could probably include || ! current_user_can( 'manage_network' ).

With those minor changes, I think we'd be set?

#3 @iandunn
4 years ago

  • Keywords needs-patch good-first-bug added; dev-feedback removed
  • Owner set to iandunn
  • Status changed from new to assigned

Setting the request as incomplete is intended to be a way for Central to inform organizers that the request they submitted is missing required information. So, rather than changing that functionality, I think it might be more intuitive for organizers if the post just starts out with a draft status -- like normal posts do -- and then moves to unpaid when an organizer "publishes" it.

Then, if it's incomplete, Central can mark it as incomplete, but it will never be a draft again.

What do you think about that approach?

#4 @jenmylo
4 years ago

I would much prefer that we use the normal Draft convention like with posts.

#5 @JustinSainton
4 years ago

That works for me, +1.

#6 @iandunn
3 years ago

  • Summary changed from Allow WordCamp site administrators to mark payment requests as incomplete to Add draft functionality to Payment Request posts

#7 @iandunn
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed by @kovshenin in r2633.

Note: See TracTickets for help on using tickets.