WordPress.org

Making WordPress.org

Changes between Initial Version and Version 1 of Ticket #1353, comment 12


Ignore:
Timestamp:
11/17/2015 08:54:13 PM (4 years ago)
Author:
coffee2code
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1353, comment 12

    initial v1  
    11The deprecation of `wp_title()` has been reverted as of [https://core.trac.wordpress.org/changeset/35624 [core-35624]].
    22
    3 The commits referencing this ticket above have converted all existing meta .org themes away from using `wp_title()` except for wporg-forums. I've attached a patch ([attachment:1353.wporg-forums.diff]) that updates the theme in the same fashion as the others. However, it includes a workaround for bbPress (which still only hooks the 'wp_title' filter but not the newer 'document_title_parts' filter). Since the deprecation has been reverted the need to update is not as pressing so it'd be better to hold off update wporg-forums until bbPress makes a related update (specifically, to filter 'document_title_parts' as an alternative to 'wp_title').
     3The commits referencing this ticket above have converted all existing meta .org themes away from using `wp_title()` except for wporg-forums. I've attached a patch ([attachment:1353.wporg-forums.diff]) that updates the theme in the same fashion as the others. However, it includes a workaround for bbPress (which still only hooks the 'wp_title' filter but not the newer 'document_title_parts' filter). Since the deprecation has been reverted the need to update is not as pressing so it'd be better to hold off updating wporg-forums until bbPress makes a related update (specifically, to filter 'document_title_parts' as an alternative to 'wp_title').