WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#1391 closed defect (fixed)

Forums Theme: missing topic title on single topic page

Reported by: francescolaffi Owned by: samuelsidler
Milestone: Priority: normal
Component: International Forums Keywords: has-patch has-screenshots
Cc:

Description

When viewing a single topic the topic title is not shown

Attachments (4)

1391.patch (637 bytes) - added by francescolaffi 4 years ago.
patch at sites/trunk/wordpress.org/ level
Screenshot 2015-11-10 13.06.23.png (135.1 KB) - added by francescolaffi 4 years ago.
1391 before-after.png (205.6 KB) - added by francescolaffi 4 years ago.
local env before-after
1391.2.diff (777 bytes) - added by netweb 4 years ago.

Download all attachments as: .zip

Change History (10)

@francescolaffi
4 years ago

patch at sites/trunk/wordpress.org/ level

@francescolaffi
4 years ago

local env before-after

@netweb
4 years ago

#1 @netweb
4 years ago

Not sure why this was missed in the original theme commits, but using bbp_show_lead_topic utilises the /wporg-forums/bbpress/content-single-topic-lead.php template part which then includes the topic title.

#2 @francescolaffi
4 years ago

thanks @netweb

tested the patch and although the page changes a bit including the lead, the template content-single-topic-lead.php does not render the title

would it be a better solution to set the lead active as done in your patch and add the title to content-single-topic-lead.php?

This ticket was mentioned in Slack in #meta by ocean90. View the logs.


3 years ago

#4 follow-up: @samuelsidler
3 years ago

I don't really know what's going on here. This is kind of a mess.

Ultimately, I took both patches in this ticket, except I changed from <h1> to <h2>.

The template part patch from @netweb just gives the initial (lead) post in a thread a different (yellow) style, but did not add the title to the page. WordPress.org is a bit behind on keeping the bbPress core theme up-to-date, so I tried upgrading it to the latest template part from bbPress.org. Still, no title was shown. The upgrade to the latest template part also changed the design even further and it looked considerably more messy.

So, I kept our old template part, called it in functions.php (patch from @netweb) and added the title to an <h2> (patch from @francescolaffi). We should really clean this all up at some point, but that's another ticket. For now, our international forums need a title. (Note: I also verified this on the ary forums.)

#5 @samuelsidler
3 years ago

  • Owner set to samuelsidler
  • Resolution set to fixed
  • Status changed from new to closed

In 2425:

International Forums: Add missing topic title on single topic pages.

Props francescolaffi, netweb.
Fixes #1391.

#6 in reply to: ↑ 4 @netweb
3 years ago

Replying to samuelsidler:

... We should really clean this all up at some point, but that's another ticket.

Created #1549 for this

Note: See TracTickets for help on using tickets.