WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#1397 closed defect (fixed)

Add 'initial-scale=1' to viewport setting in wordcamp-base-v2 for mobile friendliness

Reported by: rclilly Owned by: iandunn
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: good-first-bug has-patch
Cc:

Description

The current version of the WordCamp Base Redux theme is not mobile friendly because it omits the 'initial-scale=1' setting in the <meta name="viewport" content="width=device-width" /> tag. Need to add that without breaking backward compatibility for existing sites using the theme. The solution is to check for the site's (blog's) ID and if it's greater than the current WordCamp site's ID, add the setting, otherwise leave things as they already are.

Attachments (1)

1397.patch (641 bytes) - added by rclilly 4 years ago.
Patch for #1397

Download all attachments as: .zip

Change History (7)

#1 @rclilly
4 years ago

  • Keywords needs-patch added; has-patch removed

#2 @iandunn
4 years ago

  • Keywords good-first-bug added
  • Owner set to iandunn
  • Status changed from new to assigned

@rclilly
4 years ago

Patch for #1397

#3 @rclilly
4 years ago

  • Keywords has-patch added; needs-patch removed

#4 @iandunn
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 2092:

WordCamp Base: Add initial-scale=1 to viewport on new sites.

Fixes #1397
Props rclilly

#5 follow-up: @iandunn
4 years ago

Thanks rclilly :)

While I was reviewing this, I realized that there's a better way to handle back-compat issues like this, so r2092 introduces wcorg_skip_feature(), rather than using filters like we have in the past. I also created #1403 to convert the existing filters to use it.

#6 in reply to: ↑ 5 @rclilly
4 years ago

Replying to iandunn:

Thanks rclilly :)

While I was reviewing this, I realized that there's a better way to handle back-compat issues like this, so r2092 introduces wcorg_skip_feature(), rather than using filters like we have in the past. I also created #1403 to convert the existing filters to use it.

Thanks Ian!

Note: See TracTickets for help on using tickets.