WordPress.org
Get WordPress

Making WordPress.org

Opened 9 years ago

Closed 5 years ago

#1403 closed task (blessed) (maybelater)

Convert back-compat filters to skip-feature flags

Reported by: iandunn's profile iandunn Owned by: iandunn's profile iandunn
Milestone: Priority: low
Component: WordCamp Site & Plugins Keywords: has-patch dev-feedback
Cc:

Description

r2092 introduced a better way to handle skipping features for back-compat, but there's a bunch of existing code that uses the old filter approach. We should convert all those to use the new approach.

I think this is a complete list of the old filters:

  • wcpt_require_complete_meta_min_site_id
  • wcpt_speaker_post_avatar_min_site_id
  • wcpt_session_post_speaker_info_min_site_id
  • wcpt_speaker_post_session_info_min_site_id
  • wcb_back_compat_max_site_id
  • wcb_back_compat_site_id_exceptions

Attachments (1)

1403.diff​ (4.1 KB) - added by obenland 7 years ago.

Download all attachments as: .zip

Change History (9)

#1 @iandunn
9 years ago

  • Owner set to iandunn
  • Status changed from new to accepted

#2 @iandunn
7 years ago

  • Owner iandunn deleted
  • Status changed from accepted to assigned

#3 @iandunn
7 years ago

  • Priority changed from normal to low

#4 @obenland
7 years ago

  • Owner set to obenland
  • Status changed from assigned to accepted

@obenland
7 years ago

#5 @obenland
7 years ago

  • Keywords has-patch dev-feedback added; good-first-bug needs-patch removed
  • Owner changed from obenland to iandunn
  • Status changed from accepted to assigned

This ticket was mentioned in ​Slack in #meta-wordcamp by iandunn. ​View the logs.
5 years ago

This ticket was mentioned in ​Slack in #meta-wordcamp by iandunn. ​View the logs.
5 years ago

#8 @coreymckrill
5 years ago

  • Resolution set to maybelater
  • Status changed from assigned to closed

Closing this since it's a low priority. We can update these filters piecemeal as we are also working on adjacent code.

Note: See TracTickets for help on using tickets.