WordPress.org

Making WordPress.org

Opened 5 years ago

Closed 6 months ago

#1453 closed defect (fixed)

Better error message when non-logged in users view the newticket page

Reported by: johnbillion Owned by: dd32
Milestone: Priority: high
Component: Trac Keywords: has-ui-feedback
Cc:

Description

When linking a user to https://core.trac.wordpress.org/newticket, they see a nasty error message if they're not logged in. Can we make this error a bit more user-friendly?

https://i.imgur.com/XRBlndA.png

Attachments (4)

error message.png (360.8 KB) - added by JoshuaWold 4 years ago.
error message update.png (61.5 KB) - added by JoshuaWold 4 years ago.
actual_interface.png (87.4 KB) - added by Mte90 3 years ago.
actual interface of the page
Error Forbidden WordPress Trac-4752.jpg (35.9 KB) - added by joyously 2 years ago.
short and simple

Download all attachments as: .zip

Change History (14)

This ticket was mentioned in Slack in #meta-tracdev by drew. View the logs.


5 years ago

#2 @samuelsidler
4 years ago

  • Priority changed from normal to high

#3 @JoshuaWold
4 years ago

@samuelsidler what kind of flexibility is there in updating the error? I'm guessing we mostly have control over the wording of the error, and not the overall layout. The first thought I had was to clean it up by removing the red error part, and rewording the H1 error message. Thoughts?

Last edited 4 years ago by JoshuaWold (previous) (diff)

@Mte90
3 years ago

actual interface of the page

#4 follow-up: @Mte90
3 years ago

The message is different now so this ticket is required?

#5 in reply to: ↑ 4 @SergeyBiryukov
3 years ago

Replying to Mte90:

The message is different now so this ticket is required?

The form is there if you're already logged in.

If you're not logged in yet, there's still the same error message, exactly as reported.

#6 @Travel_girl
3 years ago

I like the suggestion from @JoshuaWold. Just the Font-size from the close button should be a bit larger, cause its pretty small and hard to read. Also do change the design of the button, could be useful, cause the color contrast of the border ist not really high.

@joyously
2 years ago

short and simple

#7 @joyously
2 years ago

  • Keywords has-ui-feedback added; ui-feedback removed

How about the styling remains the same and the text is simple: "You need to login to create a new ticket."

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


2 years ago

#9 @SergeyBiryukov
18 months ago

iIt looks like this was somewhat improved over the years by linking to
https://login.wordpress.org/?redirect_to=https://core.trac.wordpress.org/newticket instead of just https://core.trac.wordpress.org/newticket (relevant commits: [341], [361], [3139]), so that you only see the form once you're logged in, instead of the error message.

It would be great to improve the original message and get rid of the redirect_to workaround, but the message appears to be in Trac's perm.py file, and I'm not sure if there's an easy way to customize it.

#10 @dd32
6 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 9701:

Trac: Add a nicer error message when viewing the new ticket page logged out.

Props joyously for the wording.
Fixes #1453.

Note: See TracTickets for help on using tickets.