WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 5 months ago

#1466 closed defect (fixed)

Theme preview broken on anything not desktop

Reported by: karmatosed Owned by: obenland
Milestone: Priority: normal
Component: Theme Directory Keywords:
Cc:

Description (last modified by dd32)

If you try and view the theme preview on any non-desktop device it is broken. This has various degrees of issues from not scrolling to actually not showing the entire page. For example: https://make.wordpress.org/test/2015/11/12/wordpress-org-mobile-experience/#jp-carousel-3090.

The entire experience is one that means you think the theme itself is broken even if a responsive theme. Twenty Sixteen is a prime example of this problem.

It would be great to at least get previewing functional on other devices apart from desktop. At least solving the scrolling issue would be a good starting point.

Change History (3)

#1 @dd32
6 months ago

  • Description modified (diff)

I'm personally not able to duplicate this, although I'm not aware of anything that would've changed since it's been reported.

On mobile devices the theme preview chrome does take up 80% of the screen on the first load, and once you collapse it, the themes act as responsive as they usually are.

I'm not entirely sure there's much we can really do here, but I'll note that any improvements that are made in WordPress on the Theme browser should flow through to here too.

#2 @obenland
6 months ago

  • Owner set to obenland
  • Status changed from new to accepted

The trouble starts when you try to preview it for a second time. It should be just a CSS issue

#3 @obenland
5 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 6551:

Themes: Remove display classes on closing preview

Fixes a bug where the previewer thought the sidebar was open when it really wasn't.

Props karmatosed.
Fixes #1466.

Note: See TracTickets for help on using tickets.