#1498 closed enhancement (fixed)
Developer code reference should include warnings for "@access private" functions
Reported by: | netweb | Owned by: | DrewAPicture |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Developer Hub | Keywords: | has-patch has-screenshots commit |
Cc: |
Description
Currently the codex includes a warning on functions that are marked with @access private
, the developer reference does not currently include these.
e.g. Developer Reference: https://developer.wordpress.org/reference/functions/get_post_type_labels/
Vs the codex counterpart: https://codex.wordpress.org/Function_Reference/get_post_type_labels
Attachments (6)
Change History (16)
This ticket was mentioned in Slack in #docs by drew. View the logs.
9 years ago
#3
@
9 years ago
- Keywords has-patch has-screenshots added; needs-patch removed
- Type changed from defect to enhancement
#4
@
9 years ago
1498.3.diff addresses some patch feedback from @coffee2code. I also opted to leverage the 'alert' callout styles if the class is available (via the Handbook plugin):
1498.3.diff:
- Fixes a typo in a variable name
- Uses
link_internal_element()
for the new static method name (will be committed separately) - Uses the
WPorg_Handbook_Callout_Boxes
class to generate the private access message (if available) - Improves the fallback styles to better mimic the 'alert' callout styles
Note: See
TracTickets for help on using
tickets.
Added 1498.diff:
get_private_access_message()
function to retrieve the messageDevHub_Formatting::make_doclink_clickable()
into a newDevHub_Formatting::get_internal_element_link()
method. This allows us to reuse that logic for linking internal elements elsewhereprivate-access
See 1498_private_message.png for what this would look like.