Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#1507 closed defect (bug) (fixed) Showcase - String localization

Reported by: ramiy's profile ramiy Owned by: coffee2code's profile coffee2code
Milestone: Priority: normal
Component: Showcase Keywords: has-patch commit


Add i18n functions to the showcase theme.

Attachments (3)

wporg-showcase.patch (16.2 KB) - added by ramiy 8 years ago.
wporg-showcase.2.patch (16.8 KB) - added by ramiy 8 years ago.
meta-1507.patch (4.8 KB) - added by SergeyBiryukov 8 years ago.

Download all attachments as: .zip

Change History (9)

#1 @ramiy
8 years ago

  • Summary changed from Showcase i18n to Showcase - String localization

#2 @coffee2code
8 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 2376: Showcase: Pass all strings through i18n functions.

Props ramiy, coffee2code.
Fixes #1507.

#3 @SergeyBiryukov
8 years ago

  • Keywords commit added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Placeholders need a translator comment, not a context.

_x() is meant to distinguish the same string used in different contexts, e.g. _x( 'Add New', 'post' ) vs. _x( 'Add New', 'plugin' ), as it may require a different translation in each case.

See meta-1507.patch.

#4 @coffee2code
8 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 2379: Showcase: Add and fix comments to translators.

Props SergeyBiryukov.
Fixes #1507.

#5 @ocean90
8 years ago

In 2381: Showcase: Fix use of sprintf().

See #1507.

#6 @SergeyBiryukov
7 years ago

  • Component changed from General to Showcase
Note: See TracTickets for help on using tickets.