WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 2 years ago

#1507 closed defect (fixed)

WordPress.org Showcase - String localization

Reported by: ramiy Owned by: coffee2code
Milestone: Priority: normal
Component: Showcase Keywords: has-patch commit
Cc:

Description

Add i18n functions to the showcase theme.

Attachments (3)

wporg-showcase.patch (16.2 KB) - added by ramiy 4 years ago.
wporg-showcase.2.patch (16.8 KB) - added by ramiy 4 years ago.
meta-1507.patch (4.8 KB) - added by SergeyBiryukov 4 years ago.

Download all attachments as: .zip

Change History (9)

#1 @ramiy
4 years ago

  • Summary changed from Showcase i18n to WordPress.org Showcase - String localization

#2 @coffee2code
4 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 2376:

W.org Showcase: Pass all strings through i18n functions.

Props ramiy, coffee2code.
Fixes #1507.

#3 @SergeyBiryukov
4 years ago

  • Keywords commit added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Placeholders need a translator comment, not a context.

_x() is meant to distinguish the same string used in different contexts, e.g. _x( 'Add New', 'post' ) vs. _x( 'Add New', 'plugin' ), as it may require a different translation in each case.

See meta-1507.patch.

#4 @coffee2code
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 2379:

W.org Showcase: Add and fix comments to translators.

Props SergeyBiryukov.
Fixes #1507.

#5 @ocean90
4 years ago

In 2381:

W.org Showcase: Fix use of sprintf().

See #1507.

#6 @SergeyBiryukov
2 years ago

  • Component changed from General to Showcase
Note: See TracTickets for help on using tickets.