Theme Upload page confusion reducing enhancements

[mapk]

This ticket was originally to add a new description to the uploader. Ticket #1514 was about adding a checkbox to confirm licensing and such.

Since these are both about changing the uploader page in similar ways, then let's consolidate the ticket to any relevant changes to prevent the problem of people uploading themes that are not theirs, possibly from confusion related to themes acquired from elsewhere and intended to be uploaded to their own sites.

Changing description and checkbox have been suggested. Other suggestions are welcome.

[mapk]

The number on the patch doesn't match the ticket b/c I created a ticket in the wrong place already. But this should work.

[mapk]

Before:
​https://cloudup.com/iYNwzAAT5sl

After:
​https://cloudup.com/iH_arFaHSjY

[Otto42]

We already have an interim page that you have to go through:

​https://wordpress.org/themes/getting-started/

Do we really need to add more?

[mapk]

@Otto42 - based on the amount of people that still upload their themes thinking they're uploading them to their site, unfortunately, yes. This is a minor text change that might help that issue.

There are other solutions being discussed which will have a broader affect, but will also take more time. This is quick and might make a difference.

[karmatosed]

Noting we have: https://meta.trac.wordpress.org/ticket/1514 as an option to add in a checkbox. Perhaps this can be combined? Also should this be in directory or theme review?

[Otto42]

#1514 was marked as a duplicate.

[rabmalin]

Adding I agree checkbox

[rabmalin]

Patch added for adding checkbox while theme upload.

[williampatton]

Since this is the ticket where various changes to the theme directory upload page are collated there is another issue worth noting.

The page states 25mb upload limit on themes. In practice it turns out that the default php upload limit of 10mb is at play. We should sync the 2 values.

I think that 10mb is large enough size limit (does anyone disagree?) so the easiest fix is to change the text on this page to say 10mb. Alternatively the upload limit could be raised to 25mb but that would be a more involved change than just a text swap.

[obenland]

In 6345:

Themes: Make sure folks understand this is a submission.

Apparently there is still confusion around whether users can upload themes to their sites from here.

Props mapk.
See #1513.

[obenland]

I'd like to avoid adding a checkbox unless we absolutely have to. I'd rather display a big red banner that this is not a page to upload themes to one's site.

[obenland]

@williampatton Have you had trouble uploading a theme bigger than 10MB? upload_max_filesize is currently set to 50MB

[williampatton]

@obenland personally I have not had an issue as I have never uploaded a theme over 10MB.

It's been reported in the Theme Review slack channel a few times though in the past. I may be misremembering but I think it was Otto that confirmed for one of the people that had trouble to be 10MB max.

Is the post_max_size set to 50MB as well?

[obenland]

Replying to williampatton:

Is the post_max_size set to 50MB as well?

It is, yes.

Would you mind pinging me if you come across someone having that problem again? I'm happy to take a look on a concrete example. Closing for now.

[williampatton]

Can do :)