Making WordPress.org

Opened 8 years ago

Closed 3 years ago

Last modified 3 years ago

#1514 closed enhancement (fixed)

Theme uploader: add step to confirm license before upload

Reported by: karmatosed's profile karmatosed Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Theme Directory Keywords:
Cc:

Description

We've talked about this before here: https://make.wordpress.org/themes/2015/06/09/gpl-and-licence-agreement/.

What could stop people just uploading would be to add a confirmation checkbox to the process. They would have to click and agree before they upload.

Attachments (2)

Screen Shot 2021-10-05 at 4.10.32 pm.png (319.9 KB) - added by dd32 3 years ago.
Screen Shot 2021-10-05 at 4.12.24 pm.png (146.4 KB) - added by dd32 3 years ago.

Download all attachments as: .zip

Change History (15)

This ticket was mentioned in Slack in #themereview by karmatosed. View the logs.


8 years ago

#2 @Otto42
8 years ago

  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of #1513.

#3 @Otto42
8 years ago

Let's consolidate these tickets into a single idea.

This ticket was mentioned in Slack in #themereview by poena. View the logs.


3 years ago

#5 @poena
3 years ago

  • Resolution duplicate deleted
  • Status changed from closed to reopened

I am reopening this ticket as part of the work to update the review process.
A GPL check or confirmation is needed to be able to add a theme to the theme directory without manual review.

This ticket was mentioned in Slack in #themereview by poena. View the logs.


3 years ago

#7 @dd32
3 years ago

How about the above UI? It's just a quick set of <input type="checkbox" required="required">. We can add some logic to ensure that they're all checked upon upload too.

The notice shown there is simply the Chrome UI when a required form element isn't checked.

#8 @dd32
3 years ago

  • Component changed from Theme Review to Theme Directory

#9 follow-up: @poena
3 years ago

Looks good to me.
I think the first permission check can help those who upload theme copies by mistake. Maybe.

#10 in reply to: ↑ 9 @dd32
3 years ago

Replying to poena:

I think the first permission check can help those who upload theme copies by mistake. Maybe.

That was my hope in the way I worded it, to give a little hint that if that's not your intention.. you're probably in the wrong place.. and that hey, don't upload a premium theme!

The other wording I can think of was something like I am the author of this theme, and wish to upload it to WordPress.org for others to use and share., a little more explicit in actions, and less "permission" but rather more "I am author".

#11 @kafleg
3 years ago

Looks good to me as well.

#12 @dd32
3 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from reopened to closed

In 11271:

Theme Directory: Add a set of checkboxes authors must agree to before uploads can be processed.

This ensures that authors are aware of the requirements prior to the upload being processed (and we can now assume they are aware of it).

The result of these checkboxes are not stored anywhere, but the upload cannot proceed unless they're checked, so all uploads after now will have agreed with them.

Fixes #1514.

#13 @kafleg
3 years ago

Thank you @dd32

Note: See TracTickets for help on using tickets.