WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#1541 closed defect (fixed)

wp-trac.js should not link mentions in HTML attributes

Reported by: SergeyBiryukov Owned by: ocean90
Milestone: Priority: normal
Component: Trac Keywords: has-patch
Cc:

Description

See comment:4:ticket:1538 and the screenshot.

Attachments (2)

meta-1541.png (28.5 KB) - added by SergeyBiryukov 4 years ago.
meta-1541.patch (718 bytes) - added by SergeyBiryukov 4 years ago.

Download all attachments as: .zip

Change History (6)

#1 @netweb
4 years ago

I saw this earlier and was going to add a comment to the ticket, then it refreshed and vanished ¯\_(ツ)_/¯

#2 @ocean90
3 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 3141:

Trac: Don't link mentions in HTML attributes.

Props SergeyBiryukov.
Fixes #1541.

#3 @ocean90
3 years ago

In 3151:

Trac: Escape special characters in regular expressions.

See #1541.

#4 @ocean90
3 years ago

In 3167:

Trac: Improve handling of mentions in HTML attributes.

  • Revert [3151].
  • Make the regex less greedy and add support for multiline attributes.
  • Replace matches for mentions in attributes with a placeholder so other mentions in none-attributes can be still replaced.

See #1541.

Note: See TracTickets for help on using tickets.