WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#1569 closed enhancement (fixed)

Submit Plugin

Reported by: obenland Owned by:
Milestone: Priority: normal
Component: Plugin Directory Keywords:
Cc:

Description

Add the ability to upload a plugin, similar to how uploading themes works.

  • Create an upload shortcode that can be used on any site.
  • Run the uploaded files through basic checks.
  • Add links to documentation for plugin authors.

Attachments (2)

1569.diff (20.7 KB) - added by obenland 4 years ago.
1569.2.diff (19.0 KB) - added by obenland 4 years ago.

Download all attachments as: .zip

Change History (15)

#1 @obenland
4 years ago

  • Summary changed from PDv3: Submit Plugin to Submit Plugin

This ticket was mentioned in Slack in #meta by obenland. View the logs.


4 years ago

This ticket was mentioned in Slack in #meta by otto42. View the logs.


4 years ago

@obenland
4 years ago

#4 @dd32
4 years ago

@obenland Could we

  • Use post_excerpt for the short description, rather than post_content? It'll make it more consistent to use post_content for the readme, and post_excerpt for the description that way.

Should we

  • Ensure that ZIP filenames are not guessable?
  • Use a specific slug prefix for zip files?
  • Use the pending status for plugin requests?

@obenland
4 years ago

#5 @obenland
4 years ago

1569.2.diff works with namespaces, uses post_excerpt for short descriptions, and pending for new plugins.

@dd32, any specific suggestions about prefixing zip filenames and making them not guessable?

#6 @dd32
4 years ago

@obenland You could use something like wp_generate_password(8) as the prefix for the zip.

I don't think the upload handler should include a lot of the logic you've got there (All the validation of the plugin should be in a separate class for example), but commit and iterate IMHO.

#7 @obenland
4 years ago

In 2625:

Plugins Directory: Introduce plugin uploader.

Happy iterating!

Props dd32, obenland.
See #1569.

#8 @rmccue
4 years ago

r2625 uses the attachment GUID for the filename, which we want to deprecate; this needs to use get_attached_file( $zip_file->ID ) instead.

#9 @dd32
4 years ago

In 2639:

Plugin Directory: Don't rely upon the GUID.
Props rmccue.
See #1569

#10 @dd32
4 years ago

In 2640:

Plugin Directory: Upload shortcode: Abstract out the filesystem handling and cleanup remaining themes-specific logic which don't apply to plugins.
See #1569

This ticket was mentioned in Slack in #meta by obenland. View the logs.


4 years ago

#12 in reply to: ↑ description @obenland
4 years ago

  • Milestone Plugin Directory v3 - M1 deleted
  • Resolution set to fixed
  • Status changed from new to closed
  • Run the uploaded files through basic checks.
  • Add links to documentation for plugin authors.

These items will be tackled outside of this ticket. Plugin-check can be developed as a separate plugin and hooked in later, the user-facing makeup of the upload page will like change based on the IA findings.

#13 @obenland
3 years ago

In 3025:

Plugin Directory: Use plugin root directly rather than recreating it.

See #1569.

Note: See TracTickets for help on using tickets.