Clicking left or right sides of the Download WordPress button does nothing, or results in 404

[rosshanney]

This refers to the big blue button on the top right of WordPress.org pages.

On the ​wordpress.org homepage, clicking the areas of the button to the left or right of the "Download WordPress" text result in the browser navigating to ​wordpress.org/undefined, which 404s.

On other pages / areas (codex, forums, themes, plugins etc.), doing the same doesn't result in a 404, but nothing else happens either (it doesn't take you to ​wordpress.org/download, as it should).

The attached screenshot shows that the <a> element is not as wide as the styled button area.

[SergeyBiryukov]

Confirmed.

"undefined" comes from recordOutboundLink()

function recordOutboundLink(link, category, action) {
	_gaq.push(['_trackEvent', category, action])
	setTimeout('document.location = "' + link.href + '"', 100);
}

It's called when clicking on both the <a> and <li> tags:

$('#download a, .download-button').click(function() {
	recordOutboundLink(this, 'Download Links', $(this).hasClass('download-button') ? 'button' : 'nav' );
	return false;
});

However, it doesn't take into account that <li> doesn't have an href attribute.

[SergeyBiryukov]

Changing .download-button to a.download-button should fix it:

$('#download a, a.download-button').click(function() {
	recordOutboundLink(this, 'Download Links', $(this).hasClass('download-button') ? 'button' : 'nav' );
	return false;
});

Additionally, meta-159.patch​ makes the link as wide as the <li> element.

[coffee2code]

The 'download-button' class is assigned to the li, so the JS fix will have to be:

$('#download a, .download-button a').click(function() {
	recordOutboundLink(this, 'Download Links', $(this).hasClass('download-button') ? 'button' : 'nav' );
	return false;
});

[coffee2code]

In 94:

Fix internal padding of 'Download WordPress' button in header so the link fills entire button area. props SergeyBiryukov. Fixes #159.

[SergeyBiryukov]

Replying to coffee2code:

The 'download-button' class is assigned to the li, so the JS fix will have to be:

Yes, but the second selector was for the button next to "Ready to get started?", not for the one in header (which is handled by the first selector).

The current selectors are redundant and only catch the button in header.

[coffee2code]

Fixed.

You're right. I didn't realize you were addressing the second download button on the page or that the class appeared again but assigned to a different type of tag.