WordPress.org

Making WordPress.org

Opened 2 years ago

Closed 5 months ago

Last modified 5 months ago

#1594 closed defect (fixed)

Add RTL support to BrowseHappy.com

Reported by: ramiy Owned by: coffee2code
Milestone: Priority: normal
Component: Browse Happy Keywords:
Cc:

Description

Currently the BrowseHappy.com site has no RTL support.

In hebrew, for example, all the text in hebrew is LRT instead of RTL.

It's a simple CSS fix.

Change History (14)

#1 @coffee2code
2 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 2731:

Browse Happy: Add RTL support.

Fixes #1594.

#2 @ramiy
2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@coffee2code, still no RTL support...

#3 @coffee2code
2 years ago

@ramiy: What's the "simple CSS fix" I missed?

#4 @coffee2code
10 months ago

  • Keywords reporter-feedback added

@ramiy: Any additional feedback and assistance on what remains to be done for this?

#5 @SergeyBiryukov
10 months ago

Testing in Chrome set to Hebrew language, [2731] doesn't seem to work as expected. There's no dir="rtl" attribute on the <html> element, so the selectors have no effect.

#6 @SergeyBiryukov
10 months ago

language_attributes() is supposed to add dir="rtl" if is_rtl() returns true, not sure why it doesn't.

#8 @coffee2code
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 6618:

Browse Happy: Set text direction from translations.

Props obenland.
Fixes #1594.

#9 @ramiy
5 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Ok,

So I translated the string to "rtl". See https://translate.wordpress.org/projects/meta/browsehappy/he/default .

But page is still in "ltr" mode: https://browsehappy.com/?locale=he .

As @SergeyBiryukov mentioned, we need to add dir="rtl" to the main HTML tag.

When I add dir="rtl" in my console, it changes the site direction and the site looks as expected in Hebrew!

#10 @ocean90
5 months ago

  • Keywords reporter-feedback removed
  • Resolution set to fixed
  • Status changed from reopened to closed

@ramiy You have to wait until the translations have been updated.

#11 @ramiy
5 months ago

@ocean90 still no RTL...

#12 @ramiy
5 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening...

#13 @obenland
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

@coffee2code updated the translations

#14 @ramiy
5 months ago

Ok, I can confirm - It works now!

Note: See TracTickets for help on using tickets.