#1632 closed defect (bug) (fixed)
Remove link from function/hook/whatever title
Reported by: | theMikeD | Owned by: | coffee2code |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Developer Hub | Keywords: | has-patch |
Cc: |
Description
Example: https://developer.wordpress.org/reference/functions/add_meta_box/
The title should not be a link. It links to itself (which makes no sense) and it makes it difficult to copy a sub-section of it.
Attachments (2)
Change History (8)
#2
@
9 years ago
I would, yeah. Wrap it in a span and target that for styling. There' no reason for this to be a link at all is there?
This ticket was mentioned in Slack in #meta by chris_dev. View the logs.
9 years ago
#4
@
9 years ago
- Owner set to coffee2code
- Resolution set to fixed
- Status changed from new to closed
In 2767:
#5
follow-up:
↓ 6
@
9 years ago
Thanks for the patch, @chris_dev!
FYI, differences between what was committed and 1632.1.diff:
- Did not remove link from content-reference-archive.php (visitors need to actually get to pages listed in an archive).
- Retained bottom-border styling for `h1 a:hover' links (it still applies for archives).
- Adjusted text-indent (formerly a margin-left) for the various responsive breakpoints.
- Made changes to main.scss and regenerated main.css from that. (see the docs for contributing to DevHub for more info about this).
Version 0, edited 9 years ago
by
(next)
#6
in reply to:
↑ 5
@
9 years ago
Thanks for the advice, This is my first time contribute for Meta.
I will keep it in my mind about scss
Replying to coffee2code:
Thanks for the patch, @chris_dev!
FYI, differences between what was committed and 1632.1.diff:
- Did not remove link from content-reference-archive.php (visitors need to actually get to pages listed in an archive).
- Retained bottom-border styling for
h1 a:hover
links (it still applies for archives).- Adjusted text-indent (formerly a margin-left) for the various responsive breakpoints.
- Made changes to main.scss and regenerated main.css from that. (see the docs for contributing to DevHub for more info about this).
Note: See
TracTickets for help on using
tickets.
I just replaced href value to "#" cause if I get the anchor tag off, style of the title is broken.