WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 3 years ago

#1648 closed defect (fixed)

Permalinks are wrong when using the plain permalink structure

Reported by: keesiemeijer Owned by: coffee2code
Milestone: Priority: normal
Component: Developer Hub Keywords: has-patch
Cc:

Description

Permalinks for taxonomy archives and method post type posts are going to 404 pages because they use pretty permalinks even when the plain structure is set.

for example the link to the source file taxonomy page for /wp-includes/query.php should be /?wp-parser-source-file=wp-includes_query-php (if the plain structure is set). Instead it goes to /reference/files/wp-includes/query.php/

The same happens with method post permalinks. The method_permalink and taxonomy_permalink filter callbacks that change the permalinks do not use a check to see if pretty permalinks are used.


Attachments (1)

1648.patch (1.5 KB) - added by keesiemeijer 3 years ago.
Add check for pretty permalinks

Download all attachments as: .zip

Change History (3)

@keesiemeijer
3 years ago

Add check for pretty permalinks

#1 @keesiemeijer
3 years ago

  • Keywords has-patch added

#2 @coffee2code
3 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 2965:

developer.wordpress.org: Check if pretty permalinks are in use before attempting to modify permalink structure.

Props keesiemeijer.
Fixes #1648.

Note: See TracTickets for help on using tickets.