Opened 8 years ago

Closed 7 years ago

#1654 closed enhancement (fixed)

Allow import of translations as waiting

Reported by: akirk's profile akirk Owned by:
Milestone: Priority: normal
Component: Translate Site & Plugins Keywords: has-patch


For various reasons some plugin authors want to translate their plugin in interfaces other than GlotPress (i.e. outside of Therefore they ask for the ability to import translations not only in the language(s) they know but in all locales.

To maintain the translation quality at a high level, I propose the following solution: make it possible to import translations as waiting.

Then the plugin author can import their translations in any locale without them being put online right away: they still need to be approved by a (G)TE.

I have created a pull request on GlotPress-WP that extends the import with the ability to import as waiting and introduces new permissions for that.

Attachments (3)

1654.diff (873 bytes) - added by akirk 8 years ago.
1654.2.diff (722 bytes) - added by akirk 8 years ago.
The permission "import" is not going to be introduced anymore.
1654.3.diff (3.5 KB) - added by ocean90 7 years ago.

Download all attachments as: .zip

Change History (12)

8 years ago

#1 @akirk
8 years ago

  • Keywords has-patch added

This patch maps the new "import" permission to the "approve" permission and hands the permission handling of "import-waiting" back to GlotPress.

For a testing period it makes sense to directly assign this specific "import-waiting" permission to the user within GlotPress, rather than the much bigger task of enhancing the current UI for assigning that new role to a user.

8 years ago

The permission "import" is not going to be introduced anymore.

#2 @DavidAnderson
8 years ago

Why not allow plugin authors to approve also? Since they can already provide their own translations (via bundling .po/.mo files, or by cooking their own translation mechanism), it seems like an arbitrary restriction (whilst still a very welcome step forward) to only allow them to put them into the 'waiting' state.

This ticket was mentioned in Slack in #polyglots by ocean90. View the logs.

8 years ago

7 years ago

#4 @ocean90
7 years ago

1654.3.diff allows all users to import plugin/theme translations as waiting. @akirk, can I get a sanity check on 1654.3.diff?

#5 @akirk
7 years ago

The diff looks good! The only thing I noticed is that PTEs and GTEs won't be able to import as waiting on projects other than plugins or themes. But I understand this is intentional for now.

#6 @ocean90
7 years ago

In 4183:

Translate, Rosetta Roles: Allow import of translations as waiting for plugins and themes.

A PTE/GTE can import translations as waiting for all projects, logged in users only for plugins and themes.

Props akirk, ocean90.
See #1654.

#7 @zodiac1978
7 years ago

Close? ;)

This ticket was mentioned in Slack in #meta-i18n by casiepa. View the logs.

7 years ago

#9 @ocean90
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.