Allow import of translations as waiting

[akirk]

For various reasons some plugin authors want to translate their plugin in interfaces other than GlotPress (i.e. outside of translate.wordpress.org). Therefore they ask for the ability to import translations not only in the language(s) they know but in all locales.

To maintain the translation quality at a high level, I propose the following solution: make it possible to import translations as waiting.

Then the plugin author can import their translations in any locale without them being put online right away: they still need to be approved by a (G)TE.

I have created a ​pull request on GlotPress-WP that extends the import with the ability to import as waiting and introduces new permissions for that.

[akirk]

This patch maps the new "import" permission to the "approve" permission and hands the permission handling of "import-waiting" back to GlotPress.

For a testing period it makes sense to directly assign this specific "import-waiting" permission to the user within GlotPress, rather than the much bigger task of enhancing the current UI for assigning that new role to a WordPress.org user.

[akirk]

The permission "import" is not going to be introduced anymore.

[DavidAnderson]

Why not allow plugin authors to approve also? Since they can already provide their own translations (via bundling .po/.mo files, or by cooking their own translation mechanism), it seems like an arbitrary restriction (whilst still a very welcome step forward) to only allow them to put them into the 'waiting' state.

[ocean90]

1654.3.diff​ allows all users to import plugin/theme translations as waiting. @akirk, can I get a sanity check on 1654.3.diff​?

[akirk]

The diff looks good! The only thing I noticed is that PTEs and GTEs won't be able to import as waiting on projects other than plugins or themes. But I understand this is intentional for now.

[ocean90]

In 4183:

Translate, Rosetta Roles: Allow import of translations as waiting for plugins and themes.

A PTE/GTE can import translations as waiting for all projects, logged in users only for plugins and themes.

Props akirk, ocean90.
See #1654.

[zodiac1978]

Close? ;)