Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#167 closed task (blessed) (fixed)

Align assorted trac things

Reported by: samuelsidler's profile samuelsidler Owned by: nacin's profile nacin
Milestone: Priority: low
Component: Trac Keywords: has-patch


ALIGN ALL THE THINGS, is the end goal here.

The attached patch aligns the trac navigation and content area with the left edge of "Showcase". This is consistent with what we do throughout the site.

This patch does *not* align the h2 with Showcase.

(I also removed a weird border rule that isn't actually used.)

Attachments (3)

167.diff (841 bytes) - added by samuelsidler 11 years ago.
meta-167.2.diff (1.0 KB) - added by SergeyBiryukov 11 years ago.
meta-167.3.diff (284 bytes) - added by samuelsidler 11 years ago.

Download all attachments as: .zip

Change History (10)

11 years ago

#1 @samuelsidler
11 years ago

  • Keywords has-patch added

Here's a before and after shot:

#2 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 77:

Trac styles: Align the left edges. props samuelsidler. fixes #167.

#3 @nacin
11 years ago

I also had a local change for resetting the background for #headline h2 that I lumped into [77].

#4 @SergeyBiryukov
11 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

[77] brought back the issue with reports width (see comment 32 on #wp24165).

meta-167.2.diff restores full width for reports and replaces 960px references with 940px, which I guess was the intent of 167.diff.

Last edited 11 years ago by SergeyBiryukov (previous) (diff)

#5 @nacin
11 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 78:

Trac styles: Fix report width, broken in [77]. props SergeyBiryukov. fixes #167.

#6 @nacin
11 years ago

In 79:

Trac styles: Fix overeager rule added in [77]. See #167.

#7 @samuelsidler
11 years ago

The change in meta-167.2.diff misaligns the trac nav. meta-167.3.diff fixes that.

(Aside: I really dislike how pixel perfect everything is. One day, we should rewrite it to be a bit more flexible but still aligned properly.)

Note: See TracTickets for help on using tickets.