WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 3 years ago

#1701 closed enhancement (fixed)

Update trac-security.js

Reported by: jorbin Owned by: ocean90
Milestone: Priority: normal
Component: Trac Keywords: has-patch
Cc:

Description

The list of badwords hasn't been updated in the two years since we added the checkbox. This adds some more keywords.

Some are variations on existing words such as adding "vulnerable" to go with "'vulnerability and "vulnerabilities", others are new words that hadn't been considered.

Also, I feel a lot of <3 that this triggered the checkbox. However, we should make sure it is working on the meta form.

Attachments (1)

1701.diff (1.1 KB) - added by jorbin 3 years ago.

Download all attachments as: .zip

Change History (4)

@jorbin
3 years ago

This ticket was mentioned in Slack in #meta by jorbin. View the logs.


3 years ago

#2 @jorbin
3 years ago

  • Keywords has-patch added

The first part of the patch is the change to the keywords.

The second part uses the same selector to enable the button as it does to disable it. This is important on tracs like meta that use preview instead of create.

#3 @ocean90
3 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 3135:

Trac: Update trac-security.js.

Add more keywords and use the same selector to enable the submit button as it does to disable it.

Props jorbin.
Fixes #1701.

Note: See TracTickets for help on using tickets.