WordPress.org

Making WordPress.org

Opened 4 years ago

Closed 17 months ago

Last modified 15 months ago

#1734 closed defect (maybelater)

Stop reviewer from assigning themselves too many themes in a day

Reported by: grapplerulrich Owned by:
Milestone: Priority: normal
Component: Theme Review Keywords:
Cc:

Description

We have had a few cases where a malicious reviewer has taken on reviews and then closed them so that the can continue to close tickets as there is only limit of one ticket at a time but no limit if the ticket keeps on being closed.

It would something like the you are moving too fast in the forums.

Change History (6)

This ticket was mentioned in Slack in #meta by obenland. View the logs.


17 months ago

#2 @tellyworth
17 months ago

  • Resolution set to wontfix
  • Status changed from new to closed

This is an interesting idea, but we don't really have the resources to work on customizing Trac. If an issue comes up that requires it we could look for an existing mod for Trac. Closing the ticket for now, we can re-open if a specific scenario comes up.

#3 @grapplerulrich
17 months ago

Closing the ticket for now, we can re-open if a specific scenario comes up.

We had a specific senario with a malicious reviewer, reviewing and closing tickets. I can understand that this may not be an easy fix and you want to close as many tickets as possible but I don't think the reasoning for closing the ticket is valid.

CC/ @obenland

#4 @dd32
17 months ago

We had a specific senario with a malicious reviewer, reviewing and closing tickets.

That seems like the case that the reviewer shouldn't be trusted, and the reviewer should be penalised rather than penalising every reviewer.
If it was a scenario where malicious reviewers do actions like this regularly, then I'd potentially support placing limitations upon new reviewers for the first few reviews.

The reasoning for closing - Not having resources for customising Trac - is valid, although in this case it's not really relevant as the ticket assigning code isn't in Trac.

Closing this as not being something that deserves development time is a better closure reason though.
Code isn't always a solution to a People issue.

Last edited 17 months ago by dd32 (previous) (diff)

#5 @grapplerulrich
17 months ago

That seems like the case that the reviewer shouldn't be trusted, and the reviewer should be penalised rather than penalising every reviewer.

Yea, maybe I should have had the title with the issue instead of a possible solution.

If it was a scenario where malicious reviewers do actions like this regularly, then I'd potentially support placing limitations upon new reviewers for the first few reviews.

This would be a good solution for us too but I suppose that would require code too. We currently don't allow new reviewers to take on more then one ticket at a time.

Thinking of it the solution would not need to build into trac but could be built into the request a theme to review button. https://make.wordpress.org/themes/request-a-theme-to-review/

#6 @SergeyBiryukov
15 months ago

  • Resolution changed from wontfix to maybelater

Changing the resolution to maybelater, as it looks like no Trac modifications are needed here, just some additional logic for "Request a theme to review" button on make/themes.

Note: See TracTickets for help on using tickets.