WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#1750 closed defect (fixed)

Missing plural forms in Support Widget

Reported by: deconf Owned by: obenland
Milestone: Priority: normal
Component: Plugin Directory Keywords: has-patch
Cc:

Description

In support widget, to properly translate:

%1$s of %2$s support threads in the last two months have been marked resolved.

we need plural forms.

Attachments (3)

class-support.php.patch (861 bytes) - added by deconf 3 years ago.
Adds plural forms for Support Widget text
meta-1750.patch (1.3 KB) - added by SergeyBiryukov 3 years ago.
meta-1750.2.patch (1.0 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (8)

@deconf
3 years ago

Adds plural forms for Support Widget text

#1 @obenland
3 years ago

  • Milestone set to Plugin Directory v3 - M5

#2 @obenland
3 years ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from new to closed

In 3339:

Plugin Directory: Add missing singular translation form.

Props deconf.
Fixes #1750.

#3 @SergeyBiryukov
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Since "have been marked resolved" is the predicate here, it also needs to be translated depending on the number:

  • 1 of 1 support thread ... has been marked resolved.
  • 2 of 2 support threads ... have been marked resolved.
  • 1 of 5 support threads ... has been marked resolved. (This case is currently missing)
  • 2 of 5 support threads ... have been marked resolved.

Two approaches to resolve this:

  • meta-1750.patch moves %s support threads to a separate string, which makes the original one a bit more confusing to translate, but at least it can be translated correctly now.
  • meta-1750.2.patch simplifies the string so that %s support threads refers to the number of resolved threads (instead of all threads).

I'd prefer meta-1750.2.patch.

#4 @obenland
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 3344:

Plugin Directory: Make support string easier to translate.

Props SergeyBiryukov.
Fixes #1750.

#5 @samuelsidler
2 years ago

  • Milestone Plugin Directory v3 - M5 deleted

Milestone Plugin Directory v3 - M5 deleted

Note: See TracTickets for help on using tickets.