Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#1766 closed enhancement (fixed)

Handle hook deprecation in the DevHub theme

Reported by: drewapicture's profile DrewAPicture Owned by: drewapicture's profile DrewAPicture
Milestone: Priority: normal
Component: Developer Hub Keywords: has-patch


In #core10441, the core team is working on adding proper hook deprecation in the form of two new functions: apply_filters_deprecated() and do_action_deprecated().

We'll obviously need to make some adjustments to the parser to properly route the new function calls, but we also might need to adjust some minor things in the DevHub theme, such as ensuring the deprecation callout box can handle a notice for hooks and corresponding replacement hook links.

Looks like we use link_internal_element() inside of get_deprecated() to handle linking replacements, so in the interest of simplicity, we might need to add an additional case for hooks referenced simply with 'hook_name'. This would be for the context of deprecated hook docs that look like this:

 * Some now-deprecated hook.
 * @since 2.6.0
 * @deprecated 4.6.0 Use 'replacement_hook' instead.
 * @see 'replacement_hook'

We may very well already be in the clear, but it doesn't hurt to have a tracking ticket here in case there's something we're missing.

Attachments (3)

1766.diff (3.0 KB) - added by DrewAPicture 8 years ago.
1766.2.diff (3.0 KB) - added by DrewAPicture 7 years ago.
1766.3.diff (1.0 KB) - added by DrewAPicture 7 years ago.
RegEx fix

Download all attachments as: .zip

Change History (9)

8 years ago

#1 @DrewAPicture
8 years ago

  • Owner set to DrewAPicture
  • Status changed from new to accepted

1766.diff adds some handling for a few things:

  • A new string label for archive results: "Action Hook (deprecated)" or "Filter Hook (deprecated)". Since we have the opportunity to indicate deprecated status in the archive view, we should take it. Nothing worse than clicking through to what you think is a legit hook only to discover it's deprecated. I feel like we should do this for other stuff too, but that's another ticket :-)
  • Adds an optional parameter to link_internal_element() that allows us to selectively preg_match() against arbitrary content for a hook reference in the form of 'hook_name'. Currently it only handles inline @see references, e.g. {@see 'hook_name'} which come through encoded as &#8216;hook_name&#8217; This is important for handling linking for the deprecated notice, so if we do @see 'hook_name' as top-level DocBlock tag, it's still possible to parse that as a linkable hook instead of just a string.
  • Leverages two new hook types that will have to be implemented at the parser level: 'action_deprecated' and 'filter_deprecated' to make much of the above possible
  • Display deprecated hooks with apply_filters_deprecrated or do_action_deprecated in the reference single page

#2 @DrewAPicture
8 years ago

  • Keywords has-patch added

PR created for the corresponding parser changes: #178.

This ticket was mentioned in Slack in #meta-devhub by drew. View the logs.

8 years ago

7 years ago


#4 @DrewAPicture
7 years ago

Now that we actually have deprecated hooks in core, it's time to commit this. I've just merged the PR on the parser repo and refreshed the patch here. We're good to go.

@coffee2code, can you please review the patch?

#5 @coffee2code
7 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 5598: Handle hook deprecation.

Props DrewAPicture.
Fixes #1766.

7 years ago

RegEx fix

#6 @coffee2code
7 years ago

In 5606: Revert functional changes to link_internal_element() from [5598] as the need was handled in [5577].

See #1766.

Note: See TracTickets for help on using tickets.