WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#1792 closed defect (fixed)

"Tested With" Options Duplicate

Reported by: joelcj91 Owned by: obenland
Milestone: Priority: normal
Component: Plugin Directory Keywords: ui-feedback ux-feedback has-patch has-screenshots
Cc:

Description

In new plugin directory, when an author edit his plugin details, while selecting "Tested With" option, we can see that the currently selected value is duplicated and available twice. See the screenshot. 4.2.9 is repeated. (sorry for the poor quality of the picture).

https://s31.postimg.org/s03bguhsr/IMG_20160630_235228342.jpg

Attachments (4)

class-controls.php (6.4 KB) - added by joelcj91 3 years ago.
Removed unwanted loop and fixed the duplication issue.
1792.patch (1.2 KB) - added by joelcj91 3 years ago.
Patch : Removed unwanted loop and fixed the duplication issue.
1792.diff (1.2 KB) - added by joelcj91 3 years ago.
Diff file with fix
1792.2.patch (1.2 KB) - added by joelcj91 3 years ago.
Patch : Updated with coding standard (mentioned by @ocean90).

Download all attachments as: .zip

Change History (14)

@joelcj91
3 years ago

Removed unwanted loop and fixed the duplication issue.

#1 @joelcj91
3 years ago

Please ignore the php attachment and consider patch.

Last edited 3 years ago by joelcj91 (previous) (diff)

@joelcj91
3 years ago

Patch : Removed unwanted loop and fixed the duplication issue.

#2 @joelcj91
3 years ago

  • Keywords has-patch added; needs-patch removed

#3 @joelcj91
3 years ago

  • Keywords has-screenshots added

@joelcj91
3 years ago

Diff file with fix

This ticket was mentioned in Slack in #meta by j. View the logs.


3 years ago

@joelcj91
3 years ago

Patch : Updated with coding standard (mentioned by @ocean90).

This ticket was mentioned in Slack in #meta by j. View the logs.


3 years ago

#6 @obenland
3 years ago

  • Milestone set to Plugin Directory v3 - M6
  • Owner set to obenland
  • Status changed from new to reviewing

This ticket was mentioned in Slack in #meta by obenland. View the logs.


3 years ago

#8 @obenland
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 3782:

Plugin Directory: Don't append tested version when it's within the last four releases.

Fixes a bug where the tested-up-to version was only compared with older
releases in the latest four branches and not the most current one when
determining whether the version needs to be appended or not.

Props joelcj91 for initial patch.
Fixes #1792.

#9 @joelcj91
3 years ago

Thanks @obenland :) My first ticket and patch!

#10 @samuelsidler
2 years ago

  • Milestone Plugin Directory v3 - M6 deleted

Milestone Plugin Directory v3 - M6 deleted

Note: See TracTickets for help on using tickets.