Context Navigation

← Previous Ticket
Next Ticket →

#1792 closed defect (bug) (fixed)

"Tested With" Options Duplicate

Reported by:	joelcj91	Owned by:	obenland
Priority:	normal	Milestone:
Component:	Plugin Directory	Keywords:	ui-feedback ux-feedback has-patch has-screenshots
Cc:

Description

In new plugin directory, when an author edit his plugin details, while selecting "Tested With" option, we can see that the currently selected value is duplicated and available twice. See the screenshot. 4.2.9 is repeated. (sorry for the poor quality of the picture).

Attachments (4)

class-controls.php (6.4 KB ) - added by joelcj91 10 years ago.: Removed unwanted loop and fixed the duplication issue.
1792.patch (1.2 KB ) - added by joelcj91 10 years ago.: Patch : Removed unwanted loop and fixed the duplication issue.
1792.diff (1.2 KB ) - added by joelcj91 10 years ago.: Diff file with fix
1792.2.patch (1.2 KB ) - added by joelcj91 10 years ago.: Patch : Updated with coding standard (mentioned by @ocean90).

Download all attachments as: .zip

Change History (14)

@joelcj91
10 years ago

Attachment class-controls.php added

Removed unwanted loop and fixed the duplication issue.

#1 @joelcj91
10 years ago

Please ignore the previous attachment and consider below patch.

Version 1, edited 10 years ago by joelcj91 (previous) (next) (diff)

@joelcj91
10 years ago

Attachment 1792.patch added

Patch : Removed unwanted loop and fixed the duplication issue.

#2 @joelcj91
10 years ago

Keywords has-patch added; needs-patch removed

#3 @joelcj91
10 years ago

Keywords has-screenshots added

@joelcj91
10 years ago

Attachment 1792.diff added

Diff file with fix

This ticket was mentioned in Slack in #meta by j. View the logs.

10 years ago

@joelcj91
10 years ago

Attachment 1792.2.patch added

Patch : Updated with coding standard (mentioned by @ocean90).

This ticket was mentioned in Slack in #meta by j. View the logs.

10 years ago

#6 @obenland
10 years ago

Milestone → Plugin Directory v3 - M6
Owner set to obenland
Status new → reviewing

This ticket was mentioned in Slack in #meta by obenland. View the logs.

10 years ago

#8 @obenland
10 years ago

Resolution → fixed
Status reviewing → closed

In 3782:

Plugin Directory: Don't append tested version when it's within the last four releases.

Fixes a bug where the tested-up-to version was only compared with older
releases in the latest four branches and not the most current one when
determining whether the version needs to be appended or not.

Props joelcj91 for initial patch.
Fixes #1792.

#9 @joelcj91
10 years ago

Thanks @obenland :) My first ticket and patch!

#10 @samuelsidler
9 years ago

Milestone Plugin Directory v3 - M6

Milestone Plugin Directory v3 - M6 deleted

Note: See TracTickets for help on using tickets.

Download in other formats:

Making WordPress.org

Context Navigation

#1792 closed defect (bug) (fixed)

"Tested With" Options Duplicate

Description

Attachments (4)

Change History (14)

@joelcj91 10 years ago

#1 @joelcj91 10 years ago

@joelcj91 10 years ago

#2 @joelcj91 10 years ago

#3 @joelcj91 10 years ago

@joelcj91 10 years ago

This ticket was mentioned in ​Slack in #meta by j. ​View the logs. 10 years ago

@joelcj91 10 years ago

This ticket was mentioned in ​Slack in #meta by j. ​View the logs. 10 years ago

#6 @obenland 10 years ago

This ticket was mentioned in ​Slack in #meta by obenland. ​View the logs. 10 years ago

#8 @obenland 10 years ago

#9 @joelcj91 10 years ago

#10 @samuelsidler 9 years ago

Download in other formats:

@joelcj91
10 years ago

#1 @joelcj91
10 years ago

@joelcj91
10 years ago

#2 @joelcj91
10 years ago

#3 @joelcj91
10 years ago

@joelcj91
10 years ago

This ticket was mentioned in Slack in #meta by j. View the logs.

10 years ago

@joelcj91
10 years ago

This ticket was mentioned in Slack in #meta by j. View the logs.

10 years ago

#6 @obenland
10 years ago

This ticket was mentioned in Slack in #meta by obenland. View the logs.

10 years ago

#8 @obenland
10 years ago

#9 @joelcj91
10 years ago

#10 @samuelsidler
9 years ago