WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 10 months ago

#1806 closed enhancement (fixed)

Re-add subscriptions to o2

Reported by: pento Owned by:
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords:
Cc:

Description

See mu-plugins/pub/jetpack-follow-link-for-p2.php.

Attachments (1)

jetpack-follow-link-for-o2.php (5.3 KB) - added by pento 3 years ago.

Download all attachments as: .zip

Change History (7)

#1 @pento
3 years ago

Current status:

  • Ties into the o2 post model
  • Adds checkboxes to new post/comment views

TODO:

  • Reduce the number of checkboxes that are added to new post/comment views
  • Re-use code from jetpack-follow-link-for-p2.php to create the subscription
  • Add no-JS fallback

This ticket was mentioned in Slack in #meta by netweb. View the logs.


3 years ago

#3 @pento
3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [dotorg12345].

#4 @ocean90
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@pento o2_follow::subscribe_o2_comment_form() uses a variable $checked which doesn't exist.

Notice: Undefined variable: checked in /home/wporg/public_html/wp-content/mu-plugins/pub/jetpack-follow-link-for-o2.php on line 99

#5 @ocean90
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

The notice was fixed in [dotorg12352].

#6 @obenland
10 months ago

In 7334:

O2 Follow: Always use meta data as array

Fixes a fatal error where we tried to add values to an empty string when subscriptions had not been set previously.

See #1806.

Note: See TracTickets for help on using tickets.