WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 23 months ago

#1831 closed defect (fixed)

Invoice Meta Box text and visual change

Reported by: Kenshino Owned by: coreymckrill
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: dev-feedback has-patch
Cc:

Description

See https://cloudup.com/c2J7xkYnqjx

The 'Edit Existing Invoices' is a misnomer since you can't actually edit submitted invoices. It'd be more like 'See Existing Invoices', or just 'Existing Invoices'

I don't think we need a 'Add New Invoice' title to a button that says 'Add New Invoice'

Visual hierarchy as well - the 2 'section titles' should not be bigger than the meta box title.

Happy to patch if you guys agree

Attachments (1)

meta-1831.patch (1.2 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (3)

#1 @SergeyBiryukov
3 years ago

  • Keywords has-patch added; needs-patch removed

#2 @coreymckrill
23 months ago

  • Owner set to coreymckrill
  • Resolution set to fixed
  • Status changed from new to closed

In 5535:

WordCamp Sponsors: Improvements to Invoice metabox

  • De-emphasizes the "existing invoices" heading and removes the word "edit" since they can't always be edited.
  • Removes the redundant "add invoice" heading.

Note that I didn't remove the link to the existing invoice in the list,
like the original patch had, since it can still be useful to view the
invoice details, even if they can't be edited.

Props SergeyBiryukov
Fixes #1831

Note: See TracTickets for help on using tickets.