WordPress.org
Get WordPress

Making WordPress.org

Opened 8 years ago

Closed 7 years ago

#1853 closed enhancement (fixed)

Capitalize "WordPress" correctly in translations on saving

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: ocean90's profile ocean90
Milestone: Priority: normal
Component: Translate Site & Plugins Keywords: needs-patch
Cc:

Description

As ​reported by @wolly, there are ​3 old strings in Italian translation that look proper in GlotPress (with "WordPress" capitalized correctly), but not on an actual install (with a lowercase "p" in "WordPress").

translate.wordpress.org could probably use capital_P_dangit() on saving to make sure "WordPress" is always capitalized correctly in new translations.

Attachments (1)

meta-1853.patch​ (1.7 KB) - added by SergeyBiryukov 8 years ago.

Download all attachments as: .zip

Change History (5)

@SergeyBiryukov
8 years ago

#1 @SergeyBiryukov
8 years ago

meta-1853.patch​ works in my testing, but it performs an additional SQL query, as there's currently no way in GlotPress to customize translations before saving. I've opened a ​PR to introduce a filter for that.

#2 @ocean90
7 years ago

  • Keywords needs-patch added

gp_translation_prepare_for_save is now available on translate.w.org. There's no need for a new plugin, wporg-gp-customizations can be used.

#3 @ocean90
7 years ago

  • Type changed from defect to enhancement

#4 @ocean90
7 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 6741:

Translate: Apply capital_P_dangit() on translations.

Props SergeyBiryukov for initial patch.
Fixes #1853.

Note: See TracTickets for help on using tickets.